From the packager.mk code, there are two values that are supposed to go into sourcestamp.txt - the buildid, and the MOZ_SOURCE_URL, which is something like https://hg.mozilla.org/mozilla-unified/rev/123abc... The buildid part is failing with the platform.ini error, which is what the patches attached to this bug are intended to fix. Using ewong's r+'d patch seems to work locally for me, but I can't test on try (#c35). The source url isn't getting written, and doesn't look like it was ever written, because we don't set MOZILLA_OFFICIAL=1 in the mozconfig (#c27, #c28). That should be a quick change to the linux64/source mozconfig: diff --git a/browser/config/mozconfigs/linux64/source b/browser/config/mozconfigs/linux64/source index 8bc6af77a7276..8ad4faf6b3fe7 100644 --- a/browser/config/mozconfigs/linux64/source +++ b/browser/config/mozconfigs/linux64/source @@ -3,3 +3,4 @@ # extra dependencies on specific toolchains, e.g. gtk3. ac_add_options --disable-compile-environment ac_add_options --disable-nodejs +export MOZILLA_OFFICIAL=1 With ewong's patch and the mozconfig patch, I get a sourcestamp.txt file that looks like this: $ cat sourcestamp.txt 20190523160757 https://hg.mozilla.org/mozilla-unified/rev/c50b4c90d56a76d96c138adfc3562cc5f135257a Is this what we want it to look like in the end? And rail, do you have a way to test those out in automation?
Bug 1338099 Comment 45 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
From the packager.mk code, there are two values that are supposed to go into sourcestamp.txt - the buildid, and the MOZ_SOURCE_URL, which is something like https://hg.mozilla.org/mozilla-unified/rev/123abc... The buildid part is failing with the platform.ini error, which is what the patches attached to this bug are intended to fix. Using ewong's r+'d patch seems to work locally for me, but I can't test on try (#c35). The source url isn't getting written, and doesn't look like it was ever written, because we don't set MOZILLA_OFFICIAL=1 in the mozconfig (#c27, #c28). That should be a quick change to the linux64/source mozconfig: ``` diff --git a/browser/config/mozconfigs/linux64/source b/browser/config/mozconfigs/linux64/source index 8bc6af77a7276..8ad4faf6b3fe7 100644 --- a/browser/config/mozconfigs/linux64/source +++ b/browser/config/mozconfigs/linux64/source @@ -3,3 +3,4 @@ # extra dependencies on specific toolchains, e.g. gtk3. ac_add_options --disable-compile-environment ac_add_options --disable-nodejs +export MOZILLA_OFFICIAL=1 ``` With ewong's patch and the mozconfig patch, I get a sourcestamp.txt file that looks like this: $ cat sourcestamp.txt 20190523160757 https://hg.mozilla.org/mozilla-unified/rev/c50b4c90d56a76d96c138adfc3562cc5f135257a Is this what we want it to look like in the end? And rail, do you have a way to test those out in automation?