Thanks for the review. > I think it would be nice to order any missing accounts in the default way > before adding them back to the list. The API demands that all accounts returned by `browser.accounts.list()` be present in `accountIds`; this leaves in the "missing" accounts list only those that have been discarded by `accounts.list()`, i.e. IM accounts, which don't appear in the folder pane. Why does the order matter? > Nit: still missing curly brackets. ESLint seemed happy with this file. Is there another set of guidelines that I should follow? I'll fix the other two points.
Bug 1359410 Comment 34 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Thanks for the review. > I think it would be nice to order any missing accounts in the default way > before adding them back to the list. The API demands that all accounts returned by `browser.accounts.list()` be present in `accountIds`; this leaves in the "missing" accounts list only those that have been discarded by `accounts.list()`, i.e. IM accounts, which don't appear in the folder pane. Why does the order matter? > Nit: still missing curly brackets. ESLint seemed happy with this file. Is there another set of guidelines that I should follow? I'll fix the other two points.