Bug 1430766 Comment 8 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by

Jorg K (CEST = GMT+2)

on 2019-01-20 07:41:21 PST

(Hidden by Administrator)

Revision 1 by

Wayne Mery (:wsmwk)

on 2019-01-20 08:07:37 PST

I'm hijacking this bug.

Aceman, you'll hate this, but you can be my reviewer ;-) - You'll get support from some people providing feedback.

Mike, can you test this patch and see that it doesn't have negative side effects.

Kai, the `PR_C*` calls are NSPR, yes? Why on earth were those necessary? The net effect of the code is that `m_done` was being set that no one ever looked at anyway, right? Am I missing something?

There is plenty of send listener code in nsMsgCompose.cpp, but this appears to be the only use of send listener code for nsIMsgComposeParams.

A less drastic patch would be to leave that unused functionality in place, in case some add-on uses it. I'll add that, too.