Bugzilla

Review of attachment 9078013 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! Your patch looks good to me. There is just one typo.

Also, do you mind resubmitting your patch using Phabricator (Mozilla's code review server) instead of a .diff patch file? Here are instructions for creating a Phabricator account and uploading your patch:

https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html

It's pretty easy with the documentation and Mozilla's `mach` tool. If you plan to contribute more Firefox bug fixes, Phabricator will make reviewing and checking in your patches much easier for code reviewers. If you don't have the time now, that's OK. I can fix the typo and check in your patch for you. Just let me know. :)

::: netwerk/wifi/nsWifiScannerDBus.cpp
@@ +271,3 @@
>          dbus_message_iter_get_basic(&variant, &strength);
> +        int signal_strenght = (strength / 2) - 100;  // strength to dB
> +        ap->setSignal(signal_strenght);

`signal_strenght` should be spelled `signal_strength`.

Review of attachment 9078013 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! Your patch looks good to me. There is just one typo: `signal_strenght` should be spelled `signal_strength`.

Also, do you mind resubmitting your patch using Phabricator (Mozilla's code review server) instead of a .diff patch file? Here are instructions for creating a Phabricator account and uploading your patch:

https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html

It's pretty easy with the documentation and Mozilla's `mach` tool. If you plan to contribute more Firefox bug fixes, Phabricator will make reviewing and checking in your patches much easier for code reviewers. If you don't have the time now, that's OK. I can fix the typo and check in your patch for you. Just let me know. :)

::: netwerk/wifi/nsWifiScannerDBus.cpp
@@ +271,3 @@
>          dbus_message_iter_get_basic(&variant, &strength);
> +        int signal_strenght = (strength / 2) - 100;  // strength to dB
> +        ap->setSignal(signal_strenght);

`signal_strenght` should be spelled `signal_strength`.