I do not think the `[@ nsTString<T>::get]` signature belongs here, at least from looking at some of the few instances. Summarizing the status: Comment 35, comment 30 and comment 31 seem to indicate that we would want to have an early check if omni.ja exists and can be accessed such that we can inform the user about a broken install in case. The volume makes me think that it would be worth to have some comprehensive feedback for the affected users instead of crashing. FWIW wrt comment 25 in the meantime we mapped `ERROR_NOT_READY` to `NS_ERROR_FILE_DEVICE_TEMPORARY_FAILURE` in [D130905](https://phabricator.services.mozilla.com/D130905), so only `ERROR_FILE_NOT_FOUND`, `ERROR_PATH_NOT_FOUND` and `ERROR_INVALID_DRIVE` remain here, which seem to be all permanent enough conditions to fall under the "omni.ja is missing" case.
Bug 1471720 Comment 37 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
I do not think the `[@ nsTString<T>::get]` signature belongs here, at least from looking at some of the few instances. Summarizing the status: Comment 35, comment 30 and comment 31 seem to indicate that we would want to have an early check if `omni.ja` exists and can be accessed such that we can inform the user about a broken install in case. The volume makes me think that it would be worth to have some comprehensive feedback for the affected users instead of crashing. FWIW wrt comment 25 in the meantime we mapped `ERROR_NOT_READY` to `NS_ERROR_FILE_DEVICE_TEMPORARY_FAILURE` in [D130905](https://phabricator.services.mozilla.com/D130905), so only `ERROR_FILE_NOT_FOUND`, `ERROR_PATH_NOT_FOUND` and `ERROR_INVALID_DRIVE` remain here, which seem to be all permanent enough conditions to fall under the "omni.ja is missing" case.