(In reply to Magnus Melin [:mkmelin] from comment #48) Fwiw: I won't care much if the commit message gets fixed or not, now that it's already landed, but let's get the record straight. This bug has implemented an "Open containing folder" icon/button for every saved attachment item in the list of "Saved Files" tab, right? I am failing to see any of that that in the current commit message? > Thomas, well this bug was slightly confusing. If there's something missing, file a new bug with a more clear focus. Hmmm. The summary is slightly odd because it's arguably repetitive, but otherwise I am failing to locate the confusion until comment 12 where you just decided to do something related, but pretty different from the original intention and description of this bug. Kindly re-read comment 0 up to comment 11 and all of them are only talking about adding a *toolbar button* to *access the Saved Files list/tab* sometimes called "downloads list" from the main 3 pane tab. So apparently for reporter, Jörg, myself, and even newbie assignee Somu there was no confusion about the intention of this bug... > I don't see anything wrong with the commit message. > Bug 1471833: Provide icon to list / open the last saved, recent attachments from download list. r=Paenglab Imho the current commit message is misleading because this bug did NOT add an icon which allows users list the last saved attachments; we already had that list, but reporter was failing to find it because our UI does not give any easily discoverable clues about the existence of the "Saved Files" list. This bug added an icon/button to "open containing folder" of any one item in the list of "Saved Files". > The variable name is just a variable name. It's named that way because that what firefox also uses for this. Fair enough (however: pls note that the FF button has multiple functions, but ours hasn't).
Bug 1471833 Comment 49 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
(In reply to Magnus Melin [:mkmelin] from comment #48) Fwiw: I won't care much if the commit message gets fixed or not, now that it's already landed, but let's get the record straight. This bug has implemented an "Open containing folder" icon/button for every saved attachment item in the list of "Saved Files" tab, right? I am failing to see any of that that in the current commit message? > Thomas, well this bug was slightly confusing. If there's something missing, file a new bug with a more clear focus. Hmmm. The summary is slightly odd because it's arguably repetitive, but otherwise I am failing to locate the confusion until comment 12 where you just decided to do something related, but pretty different from the original intention and description of this bug. Kindly re-read comment 0 up to comment 11 and all of them are only talking about adding a *toolbar button* to *access the Saved Files list/tab* sometimes called "downloads list" from the main 3 pane tab. So apparently for reporter, Jörg, myself, and even newbie assignee Somu there was no confusion about the intention of this bug... > I don't see anything wrong with the commit message. > Bug 1471833: Provide icon to list / open the last saved, recent attachments from download list. r=Paenglab Imho the current commit message is misleading because this bug did NOT add an icon which allows users to list the last saved attachments; we already had that list, but reporter was failing to find it because our UI does not give any easily discoverable clues about the existence of the "Saved Files" list. This bug added an icon/button to "open containing folder" of any one item in the list of "Saved Files". > The variable name is just a variable name. It's named that way because that what firefox also uses for this. Fair enough (however: pls note that the FF button has multiple functions, but ours hasn't).