Bug 1486042 Comment 70 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
There is a `no_deduplicate` / `verbose_deduplicate` in the [ld64 man page](https://github.com/tpoechtrager/cctools-port/blob/master/cctools/ld64/doc/man/man1/ld.1#L547), which looks like ld64-speak for icf, and it looks like llvm explicitly [disables it](https://bugzilla.mozilla.org/show_bug.cgi?id=1486042) under certain conditions, which might explain why the crashes are only in shippable/opt builds? (Disclaimer: Not a mac user, just driving by since this looks interesting and I'm anxiously waiting for xLTO)
Revision 1 by
on 
There is a `no_deduplicate` / `verbose_deduplicate` in the [ld64 man page](https://github.com/tpoechtrager/cctools-port/blob/master/cctools/ld64/doc/man/man1/ld.1#L547), which looks like ld64-speak for icf, and it looks like llvm explicitly [disables it](https://github.com/llvm-mirror/clang/blob/ef51dce2c7d014cfe77ad7266f093ccc1b544332/lib/Driver/ToolChains/Darwin.cpp#L178) under certain conditions, which might explain why the crashes are only in shippable/opt builds? (Disclaimer: Not a mac user, just driving by since this looks interesting and I'm anxiously waiting for xLTO)

edit: fixed link
Revision 2 by
on 
There is a `no_deduplicate` / `verbose_deduplicate` in the [ld64 man page](https://github.com/tpoechtrager/cctools-port/blob/master/cctools/ld64/doc/man/man1/ld.1#L547), which looks like ld64-speak for icf, and it looks like clang explicitly [disables it](https://github.com/llvm-mirror/clang/blob/ef51dce2c7d014cfe77ad7266f093ccc1b544332/lib/Driver/ToolChains/Darwin.cpp#L178) under certain conditions, which might explain why the crashes are only in shippable/opt builds? (Disclaimer: Not a mac user, just driving by since this looks interesting and I'm anxiously waiting for xLTO)

edit: fixed link
Revision 3 by
on 
There is a `no_deduplicate` / `verbose_deduplicate` in the [ld64 man page](https://github.com/tpoechtrager/cctools-port/blob/a2e02aad90a98ac034b8d0286496450d136ebfcd/cctools/ld64/doc/man/man1/ld.1#L547), which looks like ld64-speak for icf, and it looks like clang explicitly [disables it](https://github.com/llvm-mirror/clang/blob/ef51dce2c7d014cfe77ad7266f093ccc1b544332/lib/Driver/ToolChains/Darwin.cpp#L178) under certain conditions, which might explain why the crashes are only in shippable/opt builds? (Disclaimer: Not a mac user, just driving by since this looks interesting and I'm anxiously waiting for xLTO)

edit: fixed link

Back to Bug 1486042 Comment 70