Bug 1487552 Comment 46 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Nathan Froyd [:froydnj] from comment #45)

> I meant to ask about the compiler invocation to check `#include_next <inttypes.h>`, but this is helpful too!  Can you check the log for the `#include_next <inttypes.h>` check as well?
> 

js/src> DEBUG: Creating `/var/folders/5p/x2tk851538z3dvbf5wg0x_sc0000gn/T/conftest.Ibvf7q.cpp` with content:
js/src> DEBUG: | #include_next <inttypes.h>
js/src> DEBUG: | int
js/src> DEBUG: | main(void)
js/src> DEBUG: | {
js/src> DEBUG: |
js/src> DEBUG: |   ;
js/src> DEBUG: |   return 0;
js/src> DEBUG: | }
js/src> DEBUG: Executing: `/usr/local/bin/ccache /usr/bin/clang++ -isysroot /MozillaBuilds/MacOSX10.13.sdk -std=gnu++14 /var/folders/5p/x2tk851538z3dvbf5wg0x_sc0000gn/T/c
js/src> INFO: checking for 64-bit OS...

> > > What does `bindgen` say about the compiler invocation to build the cranelift bindings?
> > 
> > I'm not sure I understand how to get the information you want here.
> 
> Ah, stylo will spit out information about what flags were used when invoking clang...I see the JS side of things doesn't do that.  I'll file a bug to fix that.
> 
> > > What are the contents of `$OBJDIR/js/src/rust/extra_bindgen_flags`?
> > 
> > -x c++ -fno-sized-deallocation -DTRACING=1 -DIMPL_LIBXUL -DMOZILLA_INTERNAL_API -DRUST_BINDGEN -DOS_POSIX=1 -DOS_MACOSX=1 -stdlib=libc++ -I/MozillaBuilds/obj/opt/dist/include/nspr
> 
> OK, so there's no `-isysroot` flag being passed here, which is probably bad.  What does your mozconfig look like?

#ac_add_options --enable-debug
#ac_add_options --disable-optimize
#ac_add_options --enable-warnings-as-errors
#ac_add_options --enable-debug-symbols

export SYS_NAME=`uname`
export CONFIG_NAME=`currentConfig`
if [ "x$SYS_NAME" = "xDarwin" ]; then
  export CC=clang
  export CXX=clang++
  #ICECC on OS X - from instructions here: https://github.com/jyavenard/mozilla-icecream
#  export CC="/usr/local/opt/llvm/bin/clang --target=x86_64-apple-darwin16.0.0 -mmacosx-version-min=10.11"
#  export CXX="/usr/local/opt/llvm/bin/clang++ --target=x86_64-apple-darwin16.0.0 -mmacosx-version-min=10.11"

#  ac_add_options --with-compiler-wrapper="/usr/local/bin/icecc"
#  mk_add_options 'export ICECC_VERSION=x86_64:/Users/mfroman/clang-icecc/clang-5.0.0-x86_64.tar.gz,Darwin17_x86_64:/Users/mfroman/clang-icecc/clang-5.0.0-Darwin17_x86_64.tar.gz'

  # to fix bug 1494022 black window travesty
  ac_add_options --with-macos-sdk=/MozillaBuilds/MacOSX10.13.sdk

  # core count of moz box, moz-build VM (on OSX desktop), and local
  export BUILD_JOBS=8
  export BUILD_OBJ_BASEDIR=/MozillaBuilds

else
  #ICECC on Linux
  export CC=$HOME/.mozbuild/clang/bin/clang
  export CXX=$HOME/.mozbuild/clang/bin/clang++

  # core count of moz box (not using icecc here yet)
  export BUILD_JOBS=28
  export BUILD_OBJ_BASEDIR=/home/mfroman/mozilla

fi

# Turn off rust optimizations to improve build times
export RUSTC_OPT_LEVEL=0
mk_add_options "export RUSTC_WRAPPER=sccache"
mk_add_options MOZ_OBJDIR=$BUILD_OBJ_BASEDIR/obj/$CONFIG_NAME
#mk_add_options 'export CCACHE_PREFIX=icecc'
mk_add_options MOZ_MAKE_FLAGS=-j$BUILD_JOBS
mk_add_options AUTOCLOBBER=1

export MOZ_WEBRTC_TESTS=1
export MOZ_WEBRTC_LEAKING_TESTS=1
export MOZ_CRASHREPORTER=1

# telemetry exports - adds lots of build time
#export MOZ_TELEMETRY_REPORTING=1
#export MOZILLA_OFFICIAL=1

# ccache stuff
ac_add_options --with-ccache
(In reply to Nathan Froyd [:froydnj] from comment #45)

> I meant to ask about the compiler invocation to check `#include_next <inttypes.h>`, but this is helpful too!  Can you check the log for the `#include_next <inttypes.h>` check as well?
> 

js/src> DEBUG: Creating `/var/folders/5p/x2tk851538z3dvbf5wg0x_sc0000gn/T/conftest.Ibvf7q.cpp` with content:
js/src> DEBUG: | #include_next <inttypes.h>
js/src> DEBUG: | int
js/src> DEBUG: | main(void)
js/src> DEBUG: | {
js/src> DEBUG: |
js/src> DEBUG: |   ;
js/src> DEBUG: |   return 0;
js/src> DEBUG: | }
js/src> DEBUG: Executing: `/usr/local/bin/ccache /usr/bin/clang++ -isysroot /MozillaBuilds/MacOSX10.13.sdk -std=gnu++14 /var/folders/5p/x2tk851538z3dvbf5wg0x_sc0000gn/T/c
js/src> INFO: checking for 64-bit OS...

> > > What does `bindgen` say about the compiler invocation to build the cranelift bindings?
> > 
> > I'm not sure I understand how to get the information you want here.
> 
> Ah, stylo will spit out information about what flags were used when invoking clang...I see the JS side of things doesn't do that.  I'll file a bug to fix that.
> 
> > > What are the contents of `$OBJDIR/js/src/rust/extra_bindgen_flags`?
> > 
> > -x c++ -fno-sized-deallocation -DTRACING=1 -DIMPL_LIBXUL -DMOZILLA_INTERNAL_API -DRUST_BINDGEN -DOS_POSIX=1 -DOS_MACOSX=1 -stdlib=libc++ -I/MozillaBuilds/obj/opt/dist/include/nspr
> 
> OK, so there's no `-isysroot` flag being passed here, which is probably bad.  What does your mozconfig look like?
```
#ac_add_options --enable-debug
#ac_add_options --disable-optimize
#ac_add_options --enable-warnings-as-errors
#ac_add_options --enable-debug-symbols

export SYS_NAME=`uname`
export CONFIG_NAME=`currentConfig`
if [ "x$SYS_NAME" = "xDarwin" ]; then
  export CC=clang
  export CXX=clang++
  #ICECC on OS X - from instructions here: https://github.com/jyavenard/mozilla-icecream
#  export CC="/usr/local/opt/llvm/bin/clang --target=x86_64-apple-darwin16.0.0 -mmacosx-version-min=10.11"
#  export CXX="/usr/local/opt/llvm/bin/clang++ --target=x86_64-apple-darwin16.0.0 -mmacosx-version-min=10.11"

#  ac_add_options --with-compiler-wrapper="/usr/local/bin/icecc"
#  mk_add_options 'export ICECC_VERSION=x86_64:/Users/mfroman/clang-icecc/clang-5.0.0-x86_64.tar.gz,Darwin17_x86_64:/Users/mfroman/clang-icecc/clang-5.0.0-Darwin17_x86_64.tar.gz'

  # to fix bug 1494022 black window travesty
  ac_add_options --with-macos-sdk=/MozillaBuilds/MacOSX10.13.sdk

  # core count of moz box, moz-build VM (on OSX desktop), and local
  export BUILD_JOBS=8
  export BUILD_OBJ_BASEDIR=/MozillaBuilds

else
  #ICECC on Linux
  export CC=$HOME/.mozbuild/clang/bin/clang
  export CXX=$HOME/.mozbuild/clang/bin/clang++

  # core count of moz box (not using icecc here yet)
  export BUILD_JOBS=28
  export BUILD_OBJ_BASEDIR=/home/mfroman/mozilla

fi

# Turn off rust optimizations to improve build times
export RUSTC_OPT_LEVEL=0
mk_add_options "export RUSTC_WRAPPER=sccache"
mk_add_options MOZ_OBJDIR=$BUILD_OBJ_BASEDIR/obj/$CONFIG_NAME
#mk_add_options 'export CCACHE_PREFIX=icecc'
mk_add_options MOZ_MAKE_FLAGS=-j$BUILD_JOBS
mk_add_options AUTOCLOBBER=1

export MOZ_WEBRTC_TESTS=1
export MOZ_WEBRTC_LEAKING_TESTS=1
export MOZ_CRASHREPORTER=1

# telemetry exports - adds lots of build time
#export MOZ_TELEMETRY_REPORTING=1
#export MOZILLA_OFFICIAL=1

# ccache stuff
ac_add_options --with-ccache
```

Back to Bug 1487552 Comment 46