Bug 1493931 Comment 21 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to mcroud from comment #18)
> Created attachment 9015201 [details]
> edit-resend-ui-v3-2x.png
Fabulous!

(In reply to Adam Holm from comment #16)
> I ask because I've been working on implementing the UI Matt gave me, through
> editing dark-theme.css
> (https://searchfox.org/mozilla-central/source/devtools/client/themes/dark-
> theme.css) and variables.css
> (https://searchfox.org/mozilla-central/source/devtools/client/themes/
> variables.css). I want to make sure that's the correct way to go about
> implementing the changes. I also want to make sure I'm following any Mozilla
> conventions for things like CSS selectors used to style elements, and any
> organization in style sheets.

I am not sure if I understand the question, but some notes:

1) Using CSS variables from variables.css is the right way to go
2) All the new styles related to the Edit and Resend form should go to a new CSS file:

devtools/client/netmonitor/src/assets/styles/CustomRequestPanel.js

That file should be included in netmonitor.css file 

Don't forget to also add the file into:
devtools\client\jar.mn


(In reply to Florens Verschelde from comment #19)
> Since I was not sure about the button placement, I made 3 demos with sticky
> buttons (buttons that remain visible even if the main content area is
> scrolled):
I think that the buttons should be at the top, so visible all the time.
Just like Matt indicated on his mockups.

Honza

Back to Bug 1493931 Comment 21