Bug 1495295 Comment 42 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Rachel Martin from comment #35)
> Any update on this?

I think that we are still fairly stuck on figuring out how to reproduce this problem. I don't really know how we can fix this problem without being able to reproduce it.

> Looks like taskbar pinning is generally broken on Windows 10 for Firefox and Thunderbird (at least on ESR).

I do not agree that it's generally broken. I just tried reproducing this bug with ESR Firefox on Windows 10 and I still cannot reproduce the issue on my machine.

> Happy to help with debugging.

I think that we mainly just need help reproducing the issue ourselves. Like I said, it's going to be very difficult for us to fix this if we can't reproduce the problem.

(In reply to Rachel Martin from comment #38)
> We've just done this: On a recently installed Windows 10 system, as admin user, downloaded the full FF installer (not the stub installer), currently at version 97. Double clicked the installer, performed a custom install, accepted all the defaults, except the maintenance service. Result: FF installed, desktop icon present, **no** taskbar icon present, so pinning didn't take place. A similar install of FF 91.6.0 on an different machine also yielded no taskbar pinned icon.

So, to be clear, this bug is about an existing pin becoming invalid after Firefox updates. It's not about the Firefox installer not pinning Firefox to the taskbar. We are aware that the installer doesn't do that on modern versions of Windows. This is because Microsoft changed things such that we cannot easily set that pin anymore. We actually [do have a way](https://searchfox.org/mozilla-central/rev/20ebe9f39e8790e2db123f89fab3293dc0a796ac/browser/components/shell/nsWindowsShellService.cpp#829) of attempting to set the pin despite this, but we do not currently call it from the installer.

--

Side note: Let's refrain from needinfo'ing :mhowell about this. She doesn't work on this anymore.
(In reply to Rachel Martin from comment #35)
> Any update on this?

I think that we are still fairly stuck on figuring out how to reproduce this problem. I don't really know how we can fix this problem without being able to reproduce it.

> Looks like taskbar pinning is generally broken on Windows 10 for Firefox and Thunderbird (at least on ESR).

I do not agree that it's generally broken. I just tried reproducing this bug with ESR Firefox on Windows 10 and I still cannot reproduce the issue on my machine.

> Happy to help with debugging.

I think that we mainly just need help reproducing the issue ourselves. Like I said, it's going to be very difficult for us to fix this if we can't reproduce the problem.

(In reply to Rachel Martin from comment #38)
> We've just done this: On a recently installed Windows 10 system, as admin user, downloaded the full FF installer (not the stub installer), currently at version 97. Double clicked the installer, performed a custom install, accepted all the defaults, except the maintenance service. Result: FF installed, desktop icon present, **no** taskbar icon present, so pinning didn't take place. A similar install of FF 91.6.0 on an different machine also yielded no taskbar pinned icon.

So, to be clear, this bug is about an existing pin becoming invalid after Firefox updates. It's not about the Firefox installer not pinning Firefox to the taskbar. We are aware that the installer doesn't do that on modern versions of Windows. This is because Microsoft changed things such that we cannot easily set that pin anymore. We actually [do have a way](https://searchfox.org/mozilla-central/rev/20ebe9f39e8790e2db123f89fab3293dc0a796ac/browser/components/shell/nsWindowsShellService.cpp#829) of attempting to set the pin despite this, but we do not currently call it from the installer.

---

Side note: Let's refrain from needinfo'ing :mhowell about this. She doesn't work on this anymore.

Back to Bug 1495295 Comment 42