Bug 1501562 Comment 103 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
(In reply to James Graham [:jgraham] from comment #102)

> Replacing `undefined` with `null` in the `window.open` seems to be enough to make this work on non-e10s. It seems like a gecko bug if that's making a difference, but assuming it works OK for geckoview too, we could take that change. Otherwise we can just mark that test as `expected:FAIL` for non-e10s on the basis that no one really cares about non-e10s desktop (and file a bug on the issue).

`null` seems to not stop the errors on geckoview: https://treeherder.mozilla.org/logviewer.html#?job_id=242104869&repo=try
Revision 1 by
on 
(In reply to James Graham [:jgraham] from comment #102)

> Replacing `undefined` with `null` in the `window.open` seems to be enough to make this work on non-e10s. It seems like a gecko bug if that's making a difference, but assuming it works OK for geckoview too, we could take that change. Otherwise we can just mark that test as `expected:FAIL` for non-e10s on the basis that no one really cares about non-e10s desktop (and file a bug on the issue).

`null` doesn't seem to stop the errors on geckoview: https://treeherder.mozilla.org/logviewer.html#?job_id=242104869&repo=try

Back to Bug 1501562 Comment 103