Bug 1503876 Comment 5 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
Suggested steps to solve: 
1. Convert `TopSiteForm.jsx` into a functional React componet 
2. Implement the same [focus trap method](https://medium.com/cstech/achieving-focus-trapping-in-a-react-modal-component-3f28f596f35b) that was [implemented on `TopicSelection.jsx`](https://searchfox.org/mozilla-central/source/browser/components/newtab/content-src/components/DiscoveryStreamComponents/TopicSelection/TopicSelection.jsx#134-181).
Revision 1 by
on 
1. Convert modal to use [HNT reusable Modal component](https://searchfox.org/mozilla-central/source/browser/components/newtab/content-src/components/ModalOverlay/ModalOverlay.jsx) 
2. Implement the same [focus trap method](https://medium.com/cstech/achieving-focus-trapping-in-a-react-modal-component-3f28f596f35b) that was [implemented on `TopicSelection.jsx`](https://searchfox.org/mozilla-central/source/browser/components/newtab/content-src/components/DiscoveryStreamComponents/TopicSelection/TopicSelection.jsx#134-181).
Revision 2 by
on 
Steps to solve modals with this issue: 

1. Convert modal to use [HNT reusable Modal component](https://searchfox.org/mozilla-central/source/browser/components/newtab/content-src/components/ModalOverlay/ModalOverlay.jsx) 
2. Implement the same [focus trap method](https://medium.com/cstech/achieving-focus-trapping-in-a-react-modal-component-3f28f596f35b) that was [implemented on `TopicSelection.jsx`](https://searchfox.org/mozilla-central/source/browser/components/newtab/content-src/components/DiscoveryStreamComponents/TopicSelection/TopicSelection.jsx#134-181).

Back to Bug 1503876 Comment 5