Bugzilla

Review of attachment 9029547 [details] [diff] [review]:
-----------------------------------------------------------------

On a new profile without anything in the address book I added debug to nsAbCardProperty::SetUID(). I saw my debug for every card I added. Then I stared TB 60 on the profile and added two addresses without UID, of course. Back in the local build, I edited those addresses and inspected the .mab file. I didn't see UIDs being added, also no debug. Wouldn't editing the card be an ideal moment to add the missing UID?

I tried auto-complete and my debug didn't show. I also switched between address books and didn't see my debug.

So I cannot confirm Aceman's or Neil's statements. Can you guys try again, maybe with:
NS_IMETHODIMP nsAbCardProperty::SetUID(const nsACString &aUID)
{
  printf("=== setting %s\n", PromiseFlatCString(aUID).get());

::: mailnews/addrbook/src/nsAbCardProperty.cpp
@@ +381,5 @@
> +
> +  nsCOMPtr<nsIAbManager> abManager = do_GetService(NS_ABMANAGER_CONTRACTID, &rv);
> +  NS_ENSURE_SUCCESS(rv, rv);
> +
> +  nsCOMPtr <nsIAbDirectory> directory = nullptr;

The CTOR does the right thing, please do not initialise to null. And lose the space before the <.