Bug 1512541 Comment 17 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Mike Hommey [:glandium] from comment #15)

> Interestingly, this was fixed upstream in http://www.openldap.org/devel/gitweb.cgi?p=openldap.git;a=commit;h=0a954f1a67410dceb0fafe202bd6c2f2f409cb4a but didn't make it into a release.

FWIW, according to the commit log for the mdb.master branch <https://github.com/LMDB/lmdb/commits/mdb.master> (which is where version 1.0 is being developed), it also didn't make it onto that branch until January 17 of this year, even though it was committed on April 12, 2017.  I suspect that it was cherry-picked from some other branch, but I don't know which one that would be, since it clearly isn't the stable branch.

Other fixes have landed on mdb.master but not on the mdb.RE/0.9 branch <https://github.com/LMDB/lmdb/commits/mdb.RE/0.9> (i.e.  current stable 0.9 release, which is what we're using in rkv).  For example, https://github.com/mozilla/lmdb-rs/pull/23 requests switching to mdb.master to fix an issue with the initial size of database files on Windows.

(I don't intend to switch to mdb.master, which is an unstable development branch; but I'm open to backporting patches from it, and I expect we'll find more that we'll want to backport.)
(In reply to Mike Hommey [:glandium] from comment #15)

> Interestingly, this was fixed upstream in http://www.openldap.org/devel/gitweb.cgi?p=openldap.git;a=commit;h=0a954f1a67410dceb0fafe202bd6c2f2f409cb4a but didn't make it into a release.

FWIW, according to the commit log for the mdb.master branch (https://github.com/LMDB/lmdb/commits/mdb.master), which is where version 1.0 is being developed, it also didn't make it onto that branch until January 17 of this year, even though it was committed on April 12, 2017.  I suspect that it was cherry-picked from some other branch, but I don't know which one that would be, since it clearly isn't the stable branch.

Other fixes have landed on mdb.master but not on the mdb.RE/0.9 branch (https://github.com/LMDB/lmdb/commits/mdb.RE/0.9), i.e. the current stable 0.9 release, which is what we're using in rkv.  For example, https://github.com/mozilla/lmdb-rs/pull/23 requests switching to mdb.master to fix an issue with the initial size of database files on Windows.

(I don't intend to switch to mdb.master, which is an unstable development branch; but I'm open to backporting patches from it, and I expect we'll find more that we'll want to backport.)

Back to Bug 1512541 Comment 17