There is a huge amount of changed incoming in Firefox 83, thus it's complicate to evaluate you concern in Firefox 82. If I set maxHistoricalSearchSuggestions to 0, in search mode (Firefox 83) I see historical suggestions, that seems wrong. I suspect the problem is here https://searchfox.org/mozilla-central/rev/25d5a4443a7e13cfa58eff38f1faa5e69f0b170f/browser/components/urlbar/UrlbarProviderSearchSuggestions.jsm#447-456 we apparently use maxHistoricalSearchSuggestions as the number of historical suggestions to show before remote suggestions, but then we still keep adding historical suggestions. There seems to be a miscommunication about what maxHistoricalSearchSuggestions is supposed to represent. Drew, do you remember why we did this?
Bug 1513459 Comment 9 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
There is a huge amount of changes incoming in Firefox 83, thus it's complicate to evaluate you concern in Firefox 82. If I set maxHistoricalSearchSuggestions to 0, in search mode (Firefox 83) I see historical suggestions, that seems wrong. I suspect the problem is here https://searchfox.org/mozilla-central/rev/25d5a4443a7e13cfa58eff38f1faa5e69f0b170f/browser/components/urlbar/UrlbarProviderSearchSuggestions.jsm#447-456 we apparently use maxHistoricalSearchSuggestions as the number of historical suggestions to show before remote suggestions, but then we still keep adding historical suggestions. There seems to be a miscommunication about what maxHistoricalSearchSuggestions is supposed to represent. Drew, do you remember why we did this?