Review of attachment 9034806 [details] [diff] [review]: ----------------------------------------------------------------- LGTM, thanks! ::: layout/base/MobileViewportManager.cpp @@ +523,5 @@ > // Update internal state. > mMobileViewportSize = viewport; > > + // ResizeReflowIgnoreOverride can kill us. > + RefPtr<MobileViewportManager> strongThis(this); you don't like the kungFuDeathGrip? :p
Bug 1515113 Comment 15 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Review of attachment 9034806 [details] [diff] [review]: ----------------------------------------------------------------- LGTM, thanks! ```patch ::: layout/base/MobileViewportManager.cpp @@ +523,5 @@ > // Update internal state. > mMobileViewportSize = viewport; > > + // ResizeReflowIgnoreOverride can kill us. > + RefPtr<MobileViewportManager> strongThis(this); ``` you don't like the kungFuDeathGrip? :p
Review of attachment 9034806 [details] [diff] [review]: LGTM, thanks! ```patch ::: layout/base/MobileViewportManager.cpp @@ +523,5 @@ > // Update internal state. > mMobileViewportSize = viewport; > > + // ResizeReflowIgnoreOverride can kill us. > + RefPtr<MobileViewportManager> strongThis(this); ``` you don't like the kungFuDeathGrip? :p