Adding followup notes from a patch We should consider doing two things here: Stop involving the WebConsoleFront. We were not calling the WebConsoleActor's methods here. There is all these functions on WebConsoleFront: https://searchfox.org/mozilla-central/rev/e0eb861a187f0bb6d994228f2e0e49b2c9ee455e/devtools/client/fronts/webconsole.js#232-410 But they should rather be on a NetworkEventFront, which doesn't exists today, but probably should! We are trying to call these methods: https://searchfox.org/mozilla-central/rev/e0eb861a187f0bb6d994228f2e0e49b2c9ee455e/devtools/server/actors/network-monitor/network-event-actor.js#152-278 Stop using DevToolsClient.request in favor of protocol.js fronts The code in WebConsoleFront is using conn.request(), this is very cryptic and deprecated. We should avoid using that. We actually would like to get rid of this request method. It keeps a lot of code alive in DevToolsClient just for this. But using protocol.js means instantiating fronts, so that we would probably have to intantiate NetworkEventFront in a transformer, similarly to what Belèn is about to introduce here: https://phabricator.services.mozilla.com/D92634#change-ddgzuOh7Fta9
Bug 1519082 Comment 10 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Adding followup notes from a patch We should consider doing two things here: Stop using the WebConsoleFront. We were not calling the WebConsoleActor's methods here. There is all these functions on WebConsoleFront which relate to networking: https://searchfox.org/mozilla-central/rev/e0eb861a187f0bb6d994228f2e0e49b2c9ee455e/devtools/client/fronts/webconsole.js#232-410 But they should rather be moved to the NetworkContentFront, here https://searchfox.org/mozilla-central/source/devtools/client/fronts/network-content.js They are trying to call these methods: https://searchfox.org/mozilla-central/rev/e0eb861a187f0bb6d994228f2e0e49b2c9ee455e/devtools/server/actors/network-monitor/network-event-actor.js#152-278 More details from Alex Stop using DevToolsClient.request in favor of protocol.js fronts The code in WebConsoleFront is using conn.request(), this is very cryptic and deprecated. We should avoid using that. We actually would like to get rid of this request method. It keeps a lot of code alive in DevToolsClient just for this. But using protocol.js means instantiating fronts, so that we would probably have to intantiate NetworkEventFront in a transformer, similarly to what Belèn is about to introduce here: https://phabricator.services.mozilla.com/D92634#change-ddgzuOh7Fta9
Adding followup notes from a patch We should consider doing two things here: Stop using the WebConsoleFront. We were not calling the WebConsoleActor's methods here. There is all these functions on WebConsoleFront which relate to networking: https://searchfox.org/mozilla-central/rev/e0eb861a187f0bb6d994228f2e0e49b2c9ee455e/devtools/client/fronts/webconsole.js#232-410 But they should rather be moved to the NetworkContentFront, here https://searchfox.org/mozilla-central/source/devtools/client/fronts/network-content.js They are trying to call these methods: https://searchfox.org/mozilla-central/rev/e0eb861a187f0bb6d994228f2e0e49b2c9ee455e/devtools/server/actors/network-monitor/network-event-actor.js#152-278 More details from Alex Stop using DevToolsClient.request in favor of protocol.js fronts The code in WebConsoleFront is using conn.request(), this is very cryptic and deprecated. We should avoid using that. We actually would like to get rid of this request method. It keeps a lot of code alive in DevToolsClient just for this. But using protocol.js means instantiating fronts, so that we would probably have to instantiate NetworkEventFront in a transformer, similarly to what Belèn is about to introduce here: https://phabricator.services.mozilla.com/D92634#change-ddgzuOh7Fta9