Bug 1521919 Comment 26 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by

PhoenixAbhishek

on 2019-03-25 05:12:38 PDT

On running tests locally using `mach xpcshell-test` I got the following output at the end

```
xpcshell
~~~~~~~~
Ran 3672 checks (180 subtests, 3492 tests)
Expected results: 3439
Skipped: 203 tests
Unexpected results: 30
  test: 18 (18 fail)
  subtest: 12 (12 fail)

Unexpected Results
------------------
dom/push/test/xpcshell/test_register_success_http2.js
  FAIL dom/push/test/xpcshell/test_register_success_http2.js - xpcshell return code: 0
dom/push/test/xpcshell/test_register_error_http2.js
  FAIL dom/push/test/xpcshell/test_register_error_http2.js - xpcshell return code: 0
dom/push/test/xpcshell/test_unregister_success_http2.js
  FAIL dom/push/test/xpcshell/test_unregister_success_http2.js - xpcshell return code: 0
dom/push/test/xpcshell/test_notification_http2.js
  FAIL dom/push/test/xpcshell/test_notification_http2.js - xpcshell return code: 0
dom/push/test/xpcshell/test_registration_success_http2.js
  FAIL dom/push/test/xpcshell/test_registration_success_http2.js - xpcshell return code: 0
netwerk/test/unit/test_immutable.js
  FAIL netwerk/test/unit/test_immutable.js - xpcshell return code: 0
  FAIL run_test - [run_test : 13] "" != ""
i:/Mozilla/mozilla-central/objdir-frontend/_tests/xpcshell/netwerk/test/unit/test_immutable.js:run_test:13
i:\Mozilla\mozilla-central\testing\xpcshell\head.js:_execute_test:520
-e:null:1
netwerk/test/unit/test_http2.js
  FAIL netwerk/test/unit/test_http2.js - xpcshell return code: 0
  FAIL testOnStopRequest - [testOnStopRequest : 79] false == true
i:/Mozilla/mozilla-central/objdir-frontend/_tests/xpcshell/netwerk/test/unit/test_http2.js:testOnStopRequest:79
i:\Mozilla\mozilla-central\testing\xpcshell\head.js:_do_main:224
i:\Mozilla\mozilla-central\testing\xpcshell\head.js:_execute_test:526
-e:null:1
netwerk/test/unit/test_altsvc.js
  FAIL netwerk/test/unit/test_altsvc.js - xpcshell return code: 0
  FAIL run_test - [run_test : 28] "" != ""
i:/Mozilla/mozilla-central/objdir-frontend/_tests/xpcshell/netwerk/test/unit/test_altsvc.js:run_test:28
i:\Mozilla\mozilla-central\testing\xpcshell\head.js:_execute_test:520
-e:null:1
netwerk/test/unit/test_header_Server_Timing.js
  FAIL netwerk/test/unit/test_header_Server_Timing.js - xpcshell return code: 0
browser/modules/test/unit/test_SitePermissions.js
  FAIL browser/modules/test/unit/test_SitePermissions.js - xpcshell return code: 0
  FAIL testNsIURI - [testNsIURI : 15] Missing expected exception. Should throw if arguments is not of type nsIURI.
i:/Mozilla/mozilla-central/objdir-frontend/_tests/xpcshell/browser/modules/test/unit/test_SitePermissions.js:testNsIURI:15
i:\Mozilla\mozilla-central\testing\xpcshell\head.js:run_next_test/_run_next_test/<:1434
i:\Mozilla\mozilla-central\testing\xpcshell\head.js:_run_next_test:1434
i:\Mozilla\mozilla-central\testing\xpcshell\head.js:run:685
i:\Mozilla\mozilla-central\testing\xpcshell\head.js:_do_main:224
i:\Mozilla\mozilla-central\testing\xpcshell\head.js:_execute_test:526
-e:null:1
netwerk/test/unit/test_anonymous-coalescing.js
  FAIL netwerk/test/unit/test_anonymous-coalescing.js - xpcshell return code: 0
  FAIL run_test - [run_test : 20] "" != ""
i:/Mozilla/mozilla-central/objdir-frontend/_tests/xpcshell/netwerk/test/unit/test_anonymous-coalescing.js:run_test:20
i:\Mozilla\mozilla-central\testing\xpcshell\head.js:_execute_test:520
-e:null:1
netwerk/test/unit/test_origin.js
  FAIL netwerk/test/unit/test_origin.js - xpcshell return code: 0
  FAIL run_test - [run_test : 14] "" != ""
i:/Mozilla/mozilla-central/objdir-frontend/_tests/xpcshell/netwerk/test/unit/test_origin.js:run_test:14
i:\Mozilla\mozilla-central\testing\xpcshell\head.js:_execute_test:520
-e:null:1
netwerk/test/unit/test_trr.js
  FAIL netwerk/test/unit/test_trr.js - xpcshell return code: 0
  FAIL run_test - [run_test : 19] "" != ""
i:/Mozilla/mozilla-central/objdir-frontend/_tests/xpcshell/netwerk/test/unit/test_trr.js:run_test:19
i:\Mozilla\mozilla-central\testing\xpcshell\head.js:_execute_test:520
-e:null:1
netwerk/test/unit/test_esni_dns_fetch.js
  FAIL netwerk/test/unit/test_esni_dns_fetch.js - xpcshell return code: 0
  FAIL run_test - [run_test : 17] "" != ""
i:/Mozilla/mozilla-central/objdir-frontend/_tests/xpcshell/netwerk/test/unit/test_esni_dns_fetch.js:run_test:17
i:\Mozilla\mozilla-central\testing\xpcshell\head.js:_execute_test:520
-e:null:1
security/manager/ssl/tests/unit/test_nonascii_path.js
  FAIL security/manager/ssl/tests/unit/test_nonascii_path.js - xpcshell return code: 0
  FAIL undefined assertion name - the profile short path should contain a non-ASCII character - false == true
i:/Mozilla/mozilla-central/objdir-frontend/_tests/xpcshell/security/manager/ssl/tests/unit/test_nonascii_path.js:null:24
i:\Mozilla\mozilla-central\testing\xpcshell\head.js:load_file:634
i:\Mozilla\mozilla-central\testing\xpcshell\head.js:_load_files:646
i:\Mozilla\mozilla-central\testing\xpcshell\head.js:_execute_test:500
-e:null:1
toolkit/components/crashes/tests/xpcshell/test_crash_manager.js
  FAIL toolkit/components/crashes/tests/xpcshell/test_crash_manager.js - xpcshell return code: 0
  FAIL test_child_process_crash_ping - [test_child_process_crash_ping : 532] 1552633200000 == 1552635000000
i:/Mozilla/mozilla-central/objdir-frontend/_tests/xpcshell/toolkit/components/crashes/tests/xpcshell/test_crash_manager.js:test_child_process_crash_ping:532
toolkit/components/search/tests/xpcshell/test_geodefaults.js
  FAIL toolkit/components/search/tests/xpcshell/test_geodefaults.js - xpcshell return code: 0
  FAIL should_get_geo_defaults_only_once - [should_get_geo_defaults_only_once : 49] "undefined" == "number"
i:/Mozilla/mozilla-central/objdir-frontend/_tests/xpcshell/toolkit/components/search/tests/xpcshell/test_geodefaults.js:cont:49
toolkit/mozapps/update/tests/unit_service_updater/checkUpdaterSigSvc.js
  FAIL toolkit/mozapps/update/tests/unit_service_updater/checkUpdaterSigSvc.js - xpcshell return code: 0
  FAIL run_test - [run_test : 37] the maintenance service exit value should be 0 - 1 == 0
i:/Mozilla/mozilla-central/objdir-frontend/_tests/xpcshell/toolkit/mozapps/update/tests/unit_service_updater/checkUpdaterSigSvc.js:run_test:37
i:\Mozilla\mozilla-central\testing\xpcshell\head.js:_execute_test:520
-e:null:1
Tests were run in parallel. Try running with --sequential to make sure the failures were not caused by this.
```

The only line where my changed file failed was at 

```
browser/modules/test/unit/test_SitePermissions.js
  FAIL browser/modules/test/unit/test_SitePermissions.js - xpcshell return code: 0
  FAIL testNsIURI - [testNsIURI : 15] Missing expected exception. Should throw if arguments is not of type nsIURI.
```

So, is this regex causing the failure of tests ->`/Not_nsIURI_Error/`

Revision 1 by

PhoenixAbhishek

on 2019-03-25 05:19:18 PDT

On running tests locally using `mach xpcshell-test` I got the following output at the end

```
xpcshell
~~~~~~~~
Ran 3672 checks (180 subtests, 3492 tests)
Expected results: 3439
Skipped: 203 tests
Unexpected results: 30
  test: 18 (18 fail)
  subtest: 12 (12 fail)

Unexpected Results
------------------
dom/push/test/xpcshell/test_register_success_http2.js
  FAIL dom/push/test/xpcshell/test_register_success_http2.js - xpcshell return code: 0
dom/push/test/xpcshell/test_register_error_http2.js
  FAIL dom/push/test/xpcshell/test_register_error_http2.js - xpcshell return code: 0
dom/push/test/xpcshell/test_unregister_success_http2.js
  FAIL dom/push/test/xpcshell/test_unregister_success_http2.js - xpcshell return code: 0
dom/push/test/xpcshell/test_notification_http2.js
  FAIL dom/push/test/xpcshell/test_notification_http2.js - xpcshell return code: 0
dom/push/test/xpcshell/test_registration_success_http2.js
  FAIL dom/push/test/xpcshell/test_registration_success_http2.js - xpcshell return code: 0
netwerk/test/unit/test_immutable.js
  FAIL netwerk/test/unit/test_immutable.js - xpcshell return code: 0
  FAIL run_test - [run_test : 13] "" != ""
i:/Mozilla/mozilla-central/objdir-frontend/_tests/xpcshell/netwerk/test/unit/test_immutable.js:run_test:13
i:\Mozilla\mozilla-central\testing\xpcshell\head.js:_execute_test:520
-e:null:1
netwerk/test/unit/test_http2.js
  FAIL netwerk/test/unit/test_http2.js - xpcshell return code: 0
  FAIL testOnStopRequest - [testOnStopRequest : 79] false == true
i:/Mozilla/mozilla-central/objdir-frontend/_tests/xpcshell/netwerk/test/unit/test_http2.js:testOnStopRequest:79
i:\Mozilla\mozilla-central\testing\xpcshell\head.js:_do_main:224
i:\Mozilla\mozilla-central\testing\xpcshell\head.js:_execute_test:526
-e:null:1
netwerk/test/unit/test_altsvc.js
  FAIL netwerk/test/unit/test_altsvc.js - xpcshell return code: 0
  FAIL run_test - [run_test : 28] "" != ""
i:/Mozilla/mozilla-central/objdir-frontend/_tests/xpcshell/netwerk/test/unit/test_altsvc.js:run_test:28
i:\Mozilla\mozilla-central\testing\xpcshell\head.js:_execute_test:520
-e:null:1
netwerk/test/unit/test_header_Server_Timing.js
  FAIL netwerk/test/unit/test_header_Server_Timing.js - xpcshell return code: 0
browser/modules/test/unit/test_SitePermissions.js
  FAIL browser/modules/test/unit/test_SitePermissions.js - xpcshell return code: 0
  FAIL testNsIURI - [testNsIURI : 15] Missing expected exception. Should throw if arguments is not of type nsIURI.
i:/Mozilla/mozilla-central/objdir-frontend/_tests/xpcshell/browser/modules/test/unit/test_SitePermissions.js:testNsIURI:15
i:\Mozilla\mozilla-central\testing\xpcshell\head.js:run_next_test/_run_next_test/<:1434
i:\Mozilla\mozilla-central\testing\xpcshell\head.js:_run_next_test:1434
i:\Mozilla\mozilla-central\testing\xpcshell\head.js:run:685
i:\Mozilla\mozilla-central\testing\xpcshell\head.js:_do_main:224
i:\Mozilla\mozilla-central\testing\xpcshell\head.js:_execute_test:526
-e:null:1
netwerk/test/unit/test_anonymous-coalescing.js
  FAIL netwerk/test/unit/test_anonymous-coalescing.js - xpcshell return code: 0
  FAIL run_test - [run_test : 20] "" != ""
i:/Mozilla/mozilla-central/objdir-frontend/_tests/xpcshell/netwerk/test/unit/test_anonymous-coalescing.js:run_test:20
i:\Mozilla\mozilla-central\testing\xpcshell\head.js:_execute_test:520
-e:null:1
netwerk/test/unit/test_origin.js
  FAIL netwerk/test/unit/test_origin.js - xpcshell return code: 0
  FAIL run_test - [run_test : 14] "" != ""
i:/Mozilla/mozilla-central/objdir-frontend/_tests/xpcshell/netwerk/test/unit/test_origin.js:run_test:14
i:\Mozilla\mozilla-central\testing\xpcshell\head.js:_execute_test:520
-e:null:1
netwerk/test/unit/test_trr.js
  FAIL netwerk/test/unit/test_trr.js - xpcshell return code: 0
  FAIL run_test - [run_test : 19] "" != ""
i:/Mozilla/mozilla-central/objdir-frontend/_tests/xpcshell/netwerk/test/unit/test_trr.js:run_test:19
i:\Mozilla\mozilla-central\testing\xpcshell\head.js:_execute_test:520
-e:null:1
netwerk/test/unit/test_esni_dns_fetch.js
  FAIL netwerk/test/unit/test_esni_dns_fetch.js - xpcshell return code: 0
  FAIL run_test - [run_test : 17] "" != ""
i:/Mozilla/mozilla-central/objdir-frontend/_tests/xpcshell/netwerk/test/unit/test_esni_dns_fetch.js:run_test:17
i:\Mozilla\mozilla-central\testing\xpcshell\head.js:_execute_test:520
-e:null:1
security/manager/ssl/tests/unit/test_nonascii_path.js
  FAIL security/manager/ssl/tests/unit/test_nonascii_path.js - xpcshell return code: 0
  FAIL undefined assertion name - the profile short path should contain a non-ASCII character - false == true
i:/Mozilla/mozilla-central/objdir-frontend/_tests/xpcshell/security/manager/ssl/tests/unit/test_nonascii_path.js:null:24
i:\Mozilla\mozilla-central\testing\xpcshell\head.js:load_file:634
i:\Mozilla\mozilla-central\testing\xpcshell\head.js:_load_files:646
i:\Mozilla\mozilla-central\testing\xpcshell\head.js:_execute_test:500
-e:null:1
toolkit/components/crashes/tests/xpcshell/test_crash_manager.js
  FAIL toolkit/components/crashes/tests/xpcshell/test_crash_manager.js - xpcshell return code: 0
  FAIL test_child_process_crash_ping - [test_child_process_crash_ping : 532] 1552633200000 == 1552635000000
i:/Mozilla/mozilla-central/objdir-frontend/_tests/xpcshell/toolkit/components/crashes/tests/xpcshell/test_crash_manager.js:test_child_process_crash_ping:532
toolkit/components/search/tests/xpcshell/test_geodefaults.js
  FAIL toolkit/components/search/tests/xpcshell/test_geodefaults.js - xpcshell return code: 0
  FAIL should_get_geo_defaults_only_once - [should_get_geo_defaults_only_once : 49] "undefined" == "number"
i:/Mozilla/mozilla-central/objdir-frontend/_tests/xpcshell/toolkit/components/search/tests/xpcshell/test_geodefaults.js:cont:49
toolkit/mozapps/update/tests/unit_service_updater/checkUpdaterSigSvc.js
  FAIL toolkit/mozapps/update/tests/unit_service_updater/checkUpdaterSigSvc.js - xpcshell return code: 0
  FAIL run_test - [run_test : 37] the maintenance service exit value should be 0 - 1 == 0
i:/Mozilla/mozilla-central/objdir-frontend/_tests/xpcshell/toolkit/mozapps/update/tests/unit_service_updater/checkUpdaterSigSvc.js:run_test:37
i:\Mozilla\mozilla-central\testing\xpcshell\head.js:_execute_test:520
-e:null:1
Tests were run in parallel. Try running with --sequential to make sure the failures were not caused by this.
```

The only line where my changed file failed was at 

```
browser/modules/test/unit/test_SitePermissions.js
  FAIL browser/modules/test/unit/test_SitePermissions.js - xpcshell return code: 0
  FAIL testNsIURI - [testNsIURI : 15] Missing expected exception. Should throw if arguments is not of type nsIURI.
```

So, is this regex causing the failure of tests ->`/Not_nsIURI_Error/` or this -> `"http://foo.com/bar/baz"`

Revision 2 by

PhoenixAbhishek

on 2019-03-25 06:23:25 PDT

On running tests locally using `mach xpcshell-test` I got the following output at the end

```
xpcshell
~~~~~~~~
Ran 3672 checks (180 subtests, 3492 tests)
Expected results: 3439
Skipped: 203 tests
Unexpected results: 30
  test: 18 (18 fail)
  subtest: 12 (12 fail)

Unexpected Results
------------------
dom/push/test/xpcshell/test_register_success_http2.js
  FAIL dom/push/test/xpcshell/test_register_success_http2.js - xpcshell return code: 0
dom/push/test/xpcshell/test_register_error_http2.js
  FAIL dom/push/test/xpcshell/test_register_error_http2.js - xpcshell return code: 0
dom/push/test/xpcshell/test_unregister_success_http2.js
  FAIL dom/push/test/xpcshell/test_unregister_success_http2.js - xpcshell return code: 0
dom/push/test/xpcshell/test_notification_http2.js
  FAIL dom/push/test/xpcshell/test_notification_http2.js - xpcshell return code: 0
dom/push/test/xpcshell/test_registration_success_http2.js
  FAIL dom/push/test/xpcshell/test_registration_success_http2.js - xpcshell return code: 0
netwerk/test/unit/test_immutable.js
  FAIL netwerk/test/unit/test_immutable.js - xpcshell return code: 0
  FAIL run_test - [run_test : 13] "" != ""
i:/Mozilla/mozilla-central/objdir-frontend/_tests/xpcshell/netwerk/test/unit/test_immutable.js:run_test:13
i:\Mozilla\mozilla-central\testing\xpcshell\head.js:_execute_test:520
-e:null:1
netwerk/test/unit/test_http2.js
  FAIL netwerk/test/unit/test_http2.js - xpcshell return code: 0
  FAIL testOnStopRequest - [testOnStopRequest : 79] false == true
i:/Mozilla/mozilla-central/objdir-frontend/_tests/xpcshell/netwerk/test/unit/test_http2.js:testOnStopRequest:79
i:\Mozilla\mozilla-central\testing\xpcshell\head.js:_do_main:224
i:\Mozilla\mozilla-central\testing\xpcshell\head.js:_execute_test:526
-e:null:1
netwerk/test/unit/test_altsvc.js
  FAIL netwerk/test/unit/test_altsvc.js - xpcshell return code: 0
  FAIL run_test - [run_test : 28] "" != ""
i:/Mozilla/mozilla-central/objdir-frontend/_tests/xpcshell/netwerk/test/unit/test_altsvc.js:run_test:28
i:\Mozilla\mozilla-central\testing\xpcshell\head.js:_execute_test:520
-e:null:1
netwerk/test/unit/test_header_Server_Timing.js
  FAIL netwerk/test/unit/test_header_Server_Timing.js - xpcshell return code: 0
browser/modules/test/unit/test_SitePermissions.js
  FAIL browser/modules/test/unit/test_SitePermissions.js - xpcshell return code: 0
  FAIL testNsIURI - [testNsIURI : 15] Missing expected exception. Should throw if arguments is not of type nsIURI.
i:/Mozilla/mozilla-central/objdir-frontend/_tests/xpcshell/browser/modules/test/unit/test_SitePermissions.js:testNsIURI:15
i:\Mozilla\mozilla-central\testing\xpcshell\head.js:run_next_test/_run_next_test/<:1434
i:\Mozilla\mozilla-central\testing\xpcshell\head.js:_run_next_test:1434
i:\Mozilla\mozilla-central\testing\xpcshell\head.js:run:685
i:\Mozilla\mozilla-central\testing\xpcshell\head.js:_do_main:224
i:\Mozilla\mozilla-central\testing\xpcshell\head.js:_execute_test:526
-e:null:1
netwerk/test/unit/test_anonymous-coalescing.js
  FAIL netwerk/test/unit/test_anonymous-coalescing.js - xpcshell return code: 0
  FAIL run_test - [run_test : 20] "" != ""
i:/Mozilla/mozilla-central/objdir-frontend/_tests/xpcshell/netwerk/test/unit/test_anonymous-coalescing.js:run_test:20
i:\Mozilla\mozilla-central\testing\xpcshell\head.js:_execute_test:520
-e:null:1
netwerk/test/unit/test_origin.js
  FAIL netwerk/test/unit/test_origin.js - xpcshell return code: 0
  FAIL run_test - [run_test : 14] "" != ""
i:/Mozilla/mozilla-central/objdir-frontend/_tests/xpcshell/netwerk/test/unit/test_origin.js:run_test:14
i:\Mozilla\mozilla-central\testing\xpcshell\head.js:_execute_test:520
-e:null:1
netwerk/test/unit/test_trr.js
  FAIL netwerk/test/unit/test_trr.js - xpcshell return code: 0
  FAIL run_test - [run_test : 19] "" != ""
i:/Mozilla/mozilla-central/objdir-frontend/_tests/xpcshell/netwerk/test/unit/test_trr.js:run_test:19
i:\Mozilla\mozilla-central\testing\xpcshell\head.js:_execute_test:520
-e:null:1
netwerk/test/unit/test_esni_dns_fetch.js
  FAIL netwerk/test/unit/test_esni_dns_fetch.js - xpcshell return code: 0
  FAIL run_test - [run_test : 17] "" != ""
i:/Mozilla/mozilla-central/objdir-frontend/_tests/xpcshell/netwerk/test/unit/test_esni_dns_fetch.js:run_test:17
i:\Mozilla\mozilla-central\testing\xpcshell\head.js:_execute_test:520
-e:null:1
security/manager/ssl/tests/unit/test_nonascii_path.js
  FAIL security/manager/ssl/tests/unit/test_nonascii_path.js - xpcshell return code: 0
  FAIL undefined assertion name - the profile short path should contain a non-ASCII character - false == true
i:/Mozilla/mozilla-central/objdir-frontend/_tests/xpcshell/security/manager/ssl/tests/unit/test_nonascii_path.js:null:24
i:\Mozilla\mozilla-central\testing\xpcshell\head.js:load_file:634
i:\Mozilla\mozilla-central\testing\xpcshell\head.js:_load_files:646
i:\Mozilla\mozilla-central\testing\xpcshell\head.js:_execute_test:500
-e:null:1
toolkit/components/crashes/tests/xpcshell/test_crash_manager.js
  FAIL toolkit/components/crashes/tests/xpcshell/test_crash_manager.js - xpcshell return code: 0
  FAIL test_child_process_crash_ping - [test_child_process_crash_ping : 532] 1552633200000 == 1552635000000
i:/Mozilla/mozilla-central/objdir-frontend/_tests/xpcshell/toolkit/components/crashes/tests/xpcshell/test_crash_manager.js:test_child_process_crash_ping:532
toolkit/components/search/tests/xpcshell/test_geodefaults.js
  FAIL toolkit/components/search/tests/xpcshell/test_geodefaults.js - xpcshell return code: 0
  FAIL should_get_geo_defaults_only_once - [should_get_geo_defaults_only_once : 49] "undefined" == "number"
i:/Mozilla/mozilla-central/objdir-frontend/_tests/xpcshell/toolkit/components/search/tests/xpcshell/test_geodefaults.js:cont:49
toolkit/mozapps/update/tests/unit_service_updater/checkUpdaterSigSvc.js
  FAIL toolkit/mozapps/update/tests/unit_service_updater/checkUpdaterSigSvc.js - xpcshell return code: 0
  FAIL run_test - [run_test : 37] the maintenance service exit value should be 0 - 1 == 0
i:/Mozilla/mozilla-central/objdir-frontend/_tests/xpcshell/toolkit/mozapps/update/tests/unit_service_updater/checkUpdaterSigSvc.js:run_test:37
i:\Mozilla\mozilla-central\testing\xpcshell\head.js:_execute_test:520
-e:null:1
Tests were run in parallel. Try running with --sequential to make sure the failures were not caused by this.
```

The only line where my changed file failed was at 

```
browser/modules/test/unit/test_SitePermissions.js
  FAIL browser/modules/test/unit/test_SitePermissions.js - xpcshell return code: 0
  FAIL testNsIURI - [testNsIURI : 15] Missing expected exception. Should throw if arguments is not of type nsIURI.
```

So, is this regex causing the failure of tests ->`/Not_nsIURI_Error/`

Back to Bug 1521919 Comment 26