I've got a PR up, it can be reviewed and landed ASAP. Can we confirm if the variant name `*_dark_theme` is ok? ([example of expected payload](https://github.com/mozilla/activity-stream/compare/master...piatra:bug1522166?expand=1#diff-b0e6b4eb9ff2bf5967836740f73ee64cR10)) this can easily be adjusted if we decide for something else we just need to decide beforehand. Which fields are expected to have a dark variant? `icon`, `title_icon`, `scene1_title_icon`, `scene2_icon` and `section_title_icon` any others? If the dark variant doesn't exist we just fallback to `light` but we need to know which to check.
Bug 1522166 Comment 11 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
I've got a PR up, it can be reviewed and landed ASAP. Can we confirm if the variant name `*_dark_theme` is ok? ([example of expected payload](https://github.com/mozilla/activity-stream/compare/master...piatra:bug1522166?expand=1#diff-b0e6b4eb9ff2bf5967836740f73ee64cR10)) this can easily be adjusted if we decide for something else we just need to decide beforehand. Which fields are expected to have a dark variant? `icon`, `title_icon`, `scene1_title_icon`, `scene2_icon` and `section_title_icon` any others? If the dark variant doesn't exist we just fallback to `light` but we need to know which to check. Just to clarify: the `*_dark_theme` variant will be loaded by default if dark theme is enabled, no other changes are required.