Thanks for your comment Francesco. By the way, I'm sorry for closing this as resolved. I meant to just add my comment, so I'll re-open this. (In reply to Francesco Lodolo [:flod] from comment #10) > (In reply to Ryan Johnson (:rjohnson) from comment #9) > > Francesco, do you know of any Firefox locale that SUMO doesn't currently gracefully handle within in-product links? > > AFAIK, there are cases where the locale is reported as `und` (bug 1537704), and these still seem to fail > https://support.allizom.org/und/products/firefox > > The approach in https://github.com/mozilla/kitsune/pull/5439 might not be scalable. For example, we add new locales from time to time (e.g. `tg` in 113): is there automation warning SUMO when that happens? No, but we could add one, or perhaps if we generalize SUMO's locale fallback mechanism for in-product links we won't need to. > Would it be possible to look at the accept-languages header instead, when the current mechanism fails? For example, `fur` and `sc` would have `it`, without SUMO making a call on what locale they should fall back to (and some users might have a different preference). Good point. I think we (SUMO) should generalize the locale fallback mechanism for in-product links, because as you noted, what we've had for years now is too manual. Yes, we could fall back based on the `Accept-Language` header.
Bug 1523590 Comment 11 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Thanks for your comment Francesco. By the way, I'm sorry for closing this as resolved. I meant to just add my comment, so I'll re-open this. (In reply to Francesco Lodolo [:flod] from comment #10) > (In reply to Ryan Johnson (:rjohnson) from comment #9) > > Francesco, do you know of any Firefox locale that SUMO doesn't currently gracefully handle within in-product links? > > AFAIK, there are cases where the locale is reported as `und` (bug 1537704), and these still seem to fail > https://support.allizom.org/und/products/firefox > > The approach in https://github.com/mozilla/kitsune/pull/5439 might not be scalable. For example, we add new locales from time to time (e.g. `tg` in 113): is there automation warning SUMO when that happens? No, but we could add one, or perhaps if we generalize SUMO's locale fallback mechanism for in-product links we won't need to. > Would it be possible to look at the accept-languages header instead, when the current mechanism fails? For example, `fur` and `sc` would have `it`, without SUMO making a call on what locale they should fall back to (and some users might have a different preference). Good point. I think we (SUMO) should generalize the locale fallback mechanism for in-product links, because as you noted, what we've had for years now is too manual. Yes, we could fall back based on the `Accept-Language` header. I'll add an issue in our GitHub repo to track this. Thanks!