Bugzilla

(In reply to Brian Grinstead [:bgrins] from comment #66)
> Comment on attachment 9043565 [details] [diff] [review]
> Part 1.3: Use Shadow DOM for slotting children, r=bgrins
> 
> Review of attachment 9043565 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: toolkit/content/widgets/tree.js
> @@ +995,4 @@
> >  
> >      get inputField() {
> >        if (!this._inputField)
> > +        this._inputField = this.shadowRoot.querySelector("[anonid=input]");
> 
> While we are here we may as well remove the anonid attribute from this
> element and `return this.shadowRoot.querySelector(".tree-input")`

Sure.

> ::: toolkit/themes/shared/in-content/common.inc.css
> @@ -385,4 @@
> >    padding-left: 8px;
> >  }
> >  
> 
> Could you do a bit of checking around to see if we ever render inputs in our
> known in-content tree consumers, and if so if they look different
> before/after this patch?

Will do. Everything else looks ok otherwise?

(In reply to Brian Grinstead [:bgrins] from comment #66)
> 
> While we are here we may as well remove the anonid attribute from this
> element and `return this.shadowRoot.querySelector(".tree-input")`

Sure.

> ::: toolkit/themes/shared/in-content/common.inc.css
> @@ -385,4 @@
> >    padding-left: 8px;
> >  }
> >  
> 
> Could you do a bit of checking around to see if we ever render inputs in our
> known in-content tree consumers, and if so if they look different
> before/after this patch?

Will do. Everything else looks ok otherwise?