Bug 1525330 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Our code has some branching on SharedArrayBuffer where it'll throw, as implemented in https://hg.mozilla.org/mozilla-central/rev/91fe35e7df1fa3124c266c249ad0907320dfd956, but this lacks at least XMLHttpRequest on the main thread and might also lack APIs added since then.

Given that SharedArrayBuffer has been disabled it's in general not clear how well all of this is maintained.

Implementing [AllowShared] in IDL and using that would help here us move to a somewhat less fragile setup.

Note that the plan is to unconditionally enable SharedArrayBuffer in due course and allow require opt-in for cross-thread usage (i.e., usage that would allow for creating a timer). This means that places where do intentionally allow it, as in WebGL, also require a further audit to see if they require this additional opt-in as well.

(See also https://github.com/heycam/webidl/issues/638 for some further ideas on potentially refining [AllowShared].)
Our code has some branching on SharedArrayBuffer where it'll throw, as implemented in https://hg.mozilla.org/mozilla-central/rev/91fe35e7df1fa3124c266c249ad0907320dfd956, but this lacks at least XMLHttpRequest on the main thread and might also lack APIs added since then.

Given that SharedArrayBuffer has been disabled it's in general not clear how well all of this is maintained.

Implementing [AllowShared] in IDL and using that would help here us move to a somewhat less fragile setup.

Note that the plan is to unconditionally enable SharedArrayBuffer in due course and require opt-in for cross-thread usage (i.e., usage that would allow for creating a timer). This means that places where do intentionally allow it, as in WebGL, require a further audit to see if they require this additional opt-in as well.

(See also https://github.com/heycam/webidl/issues/638 for some further ideas on potentially refining [AllowShared].)

Back to Bug 1525330 Comment 0