Bugzilla

Hi all,

I want to chime in here and kindly ask not to handle this bug at this time. The TextProperty terminology is still used widely in the codebase, particularly in tests.

Also, we have two versions of the Rules panel, one legacy and still active, and one React/Redux-based not yet enabled. The legacy version makes extensive use of TextProperty. The new one transitioned to Declaration, but still relies on code shared with the legacy version (models/element-style.js models/text-property-editor.js, etc.)

I'm reviewing a big patch in bug 1596093 for updating just a few tests to a `getTextProperty()` helper (to be renamed later to `getDeclaration()`) and the amount of `rule.textProp` instances in tests is still very large. Many tests will need to updated so the terminology makes sense.

A clearer course of action would be:
- postpone working on this task to rename `TextProperty` to `Declaration`
- continue work on the new Rules panel (which already uses the "declaration" terminology)
- fix tests to ensure they work with new Rules panel
- remove the legacy Rules panel (and with it all the "TextProperty' naming)
- update the leftover `TextProperty` instances to `Declaration` in tests and other files.

So, for now, please do not address this task.

Uday, to avoid situations like these in the future, it helps to announce that you want to work on a bug before starting on it. Team members will be happy to provide guidance. For some bugs, like this one, there is more nuance involved than what's in the bug description. As Gabriel mentioned in [comment #5](https://bugzilla.mozilla.org/show_bug.cgi?id=1525992#c5), this is not really a good-first-bug to start on.

Hi all,

I want to chime in here and kindly ask not to handle this bug at this time. The TextProperty terminology is still used widely in the codebase, particularly in tests.

Also, we have two versions of the Rules panel, one legacy and still active, and one React/Redux-based not yet enabled. The legacy version makes extensive use of TextProperty. The new one transitioned to Declaration, but still relies on code shared with the legacy version (models/element-style.js models/text-property-editor.js, etc.)

I'm reviewing a big patch in bug 1596093 for updating just a few tests to a `getTextProperty()` helper (to be renamed later to `getDeclaration()`) and the amount of `rule.textProp` instances in tests is still very large. Many tests will need to be updated so the terminology makes sense.

A clearer course of action would be:
- postpone working on this task to rename `TextProperty` to `Declaration`
- continue work on the new Rules panel (which already uses the "declaration" terminology)
- fix tests to ensure they work with new Rules panel
- remove the legacy Rules panel (and with it all the "TextProperty' naming)
- update the leftover `TextProperty` instances to `Declaration` in tests and other files.

So, for now, please do not address this task.

Uday, to avoid situations like these in the future, it helps to announce that you want to work on a bug before starting on it. Team members will be happy to provide guidance. For some bugs, like this one, there is more nuance involved than what's in the bug description. As Gabriel mentioned in [comment #5](https://bugzilla.mozilla.org/show_bug.cgi?id=1525992#c5), this is not really a good-first-bug to start on.