Bug 1526387 Comment 2 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
Specifically, this probably happens right now via the following chain of function calls:
 - addRecommendation() gets called to create the recommendation
 - ...and it calls _maybeAddAddonInstallURL()
 - ...which calls _fetchLatestAddonVersion()
 - ...which pings the addons API with the ID of the addon that we're recommending
Revision 1 by
on 
Specifically, this probably happens right now via the following chain of function calls:
 - addRecommendation() gets called to create the recommendation
 - ...and it calls _maybeAddAddonInstallURL()
 - ...which calls _fetchLatestAddonVersion()
 - ...which pings the addons API with the ID of the addon that we're recommending

Source, for reference:
https://searchfox.org/mozilla-central/rev/03ebbdab952409640c6857d835d3040bf6f9e2db/browser/components/newtab/lib/CFRPageActions.jsm#512

It's the up-front "_maybeAddAddonInstallURL" call that is problematic here, I think.
Revision 2 by
on 
Specifically, this probably happens right now via the following chain of function calls:
 - addRecommendation() gets called to create the recommendation
 - ...and it calls _maybeAddAddonInstallURL()
 - ...which calls _fetchLatestAddonVersion()
 - ...which pings the addons API with the ID of the addon that we're recommending

Source, for reference:
https://searchfox.org/mozilla-central/rev/03ebbdab952409640c6857d835d3040bf6f9e2db/browser/components/newtab/lib/CFRPageActions.jsm#512

Back to Bug 1526387 Comment 2