Bug 1526387 Comment 6 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

## Beta/Release Uplift Approval Request

### Feature/Bug causing the regression

None

### User impact if declined

There is a privacy issue with CFR campaigns that suggest AMO addons leaking the site the user is getting the recommendation from

### Is this code covered by automated tests?

Yes

### Has the fix been verified in Nightly?

No

### Needs manual test from QE?

Yes

### If yes, steps to reproduce

- pref on asrouter dev tools browser.newtabpage.activity-stream.asrouter.devtoolsEnabled
- go to about:newtab#asrouter
- open a browser console (Ctrl+Shift+J) and tell it to show XHR
- using about:newtab#asrouter, force a CFR recommendation to show

Expected Result:

You should *not* see an XHR for https://services.addons.mozilla.org/api

ALSO:

Please ensure existing CFR actions and functionality as described in the Test Suite: https://goo.gl/jM45bW;

### List of other uplifts needed

None

### Risk to taking this patch

Low

### Why is the change risky/not risky? (and alternatives if risky)

CFR is a new feature that doesn't affect all users.  If it is broken, the worst that can happen is a missing recommendation.  The patch is reasonably small.

### String changes made/needed

none
## Beta/Release Uplift Approval Request

### Feature/Bug causing the regression

https://bugzilla.mozilla.org/show_bug.cgi?id=1471328

### User impact if declined

There is a privacy issue with CFR campaigns that suggest AMO addons leaking the site the user is getting the recommendation from

### Is this code covered by automated tests?

Yes

### Has the fix been verified in Nightly?

No

### Needs manual test from QE?

Yes

### If yes, steps to reproduce

- pref on asrouter dev tools browser.newtabpage.activity-stream.asrouter.devtoolsEnabled
- go to about:newtab#asrouter
- open a browser console (Ctrl+Shift+J) and tell it to show XHR
- using about:newtab#asrouter, force a CFR recommendation to show

Expected Result:

You should *not* see an XHR for https://services.addons.mozilla.org/api

ALSO:

Please ensure existing CFR actions and functionality as described in the Test Suite: https://goo.gl/jM45bW;

### List of other uplifts needed

None

### Risk to taking this patch

Low

### Why is the change risky/not risky? (and alternatives if risky)

CFR is a new feature that doesn't affect all users.  If it is broken, the worst that can happen is a missing recommendation.  The patch is reasonably small.

### String changes made/needed

none

Back to Bug 1526387 Comment 6