Bug 1528859 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Currently MOZ_PROFILER_SHUTDOWN only ends up producing the profile for the main thread.

(In fact, it's producing all of them, but they use the same name, and the main thread goes last and overwrites previous threads!)

I'm proposing to change the meaning of the MOZ_PROFILER_SHUTDOWN arguments, from a full filename to a prefix name, so that each process may output its own profile in a separate file.
E.g., `MOZ_PROFILER_SHUTDOWN="prof-"` will generate "prof-123.json", "prof-127.json", where the numbers are process IDs.

It's not ideal, but I think it would be a good & easy first step until we can implement a better (more complicated) solution.
Maybe a small external utility could be created to stitch multiple profiles together, if deemed useful?

I've got a WIP patch working, I'll submit it for review soon, but please give feedback/criticism if you think of anything.
Currently MOZ_PROFILER_SHUTDOWN only ends up producing the profile for the main thread.

(In fact, it's producing all of them, but they use the same name, and the main thread goes last and overwrites previous sub-process files!)

I'm proposing to change the meaning of the MOZ_PROFILER_SHUTDOWN arguments, from a full filename to a prefix name, so that each process may output its own profile in a separate file.
E.g., `MOZ_PROFILER_SHUTDOWN="prof-"` will generate "prof-123.json", "prof-127.json", where the numbers are process IDs.

It's not ideal, but I think it would be a good & easy first step until we can implement a better (more complicated) solution.
Maybe a small external utility could be created to stitch multiple profiles together, if deemed useful?

I've got a WIP patch working, I'll submit it for review soon, but please give feedback/criticism if you think of anything.

Back to Bug 1528859 Comment 0