I'm getting failures with leakchecks now in Windows debug, plus some other mysterious errors around
Bug 1529125 Comment 15 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
I'm getting failures with leak checks now in Windows debug, plus some other mysterious assertion errors around the Windows implementation of PoisonIOInterposer. I'm going to try narrow the scope of this patch a bit, and attempt to land the xpcshell part only, then follow-up with more investigation into the windows error with adding the initialization to the content process. ``` 15:12:41 INFO - PID 9568 | Assertion failure: false (MOZ_ASSERT_UNREACHABLE: Unrecognized opcode sequence), at z:/build/build/src/obj-firefox/dist/include/mozilla/interceptor/PatcherDetour.h:840 15:13:01 INFO - PID 9568 | #01: static int mozilla::interceptor::FuncHook<mozilla::interceptor::WindowsDllInterceptor<mozilla::interceptor::VMSharingPolicyShared<mozilla::interceptor::MMPolicyInProcess,128> >,long (*)(void **, unsigned long, _OBJECT_ATTRIBUTES *, _IO_STATUS_BLOCK *, _LARGE_INTEGER *, unsigned long, unsigned long, unsigned long, unsigned long, void *, unsigned long)>::InitOnceCallback(union _RTL_RUN_ONCE *, void *, void * *) [mozglue/misc/nsWindowsDllInterceptor.h:194] 15:13:01 INFO - 15:13:01 INFO - PID 9568 | #02: ntdll.dll + 0x2285f 15:13:01 INFO - 15:13:01 INFO - PID 9568 | #03: KERNELBASE.dll + 0x539ca 15:13:01 INFO - 15:13:01 INFO - PID 9568 | #04: mozilla::InitPoisonIOInterposer() [xpcom/build/PoisonIOInterposerWin.cpp:352] 15:13:01 INFO - 15:13:01 INFO - PID 9568 | #05: mozilla::IOInterposer::Init() [xpcom/build/IOInterposer.cpp:406] 15:13:01 INFO - 15:13:01 INFO - PID 9568 | #06: XRE_InitChildProcess(int,char * * const,XREChildData const *) [toolkit/xre/nsEmbedFunctions.cpp:382] 15:13:01 INFO - 15:13:02 INFO - PID 9568 | #07: NS_internal_main(int,char * *,char * *) [browser/app/nsBrowserApp.cpp:265] 15:13:02 INFO - 15:13:02 INFO - PID 9568 | #08: wmain [toolkit/xre/nsWindowsWMain.cpp:129] 15:13:02 INFO - 15:13:02 INFO - PID 9568 | #09: static int __scrt_common_main_seh() [f:/dd/vctools/crt/vcstartup/src/startup/exe_common.inl:288] 15:13:02 INFO - 15:13:02 INFO - PID 9568 | #10: KERNEL32.DLL + 0x13034 15:13:02 INFO - 15:13:02 INFO - PID 9568 | #11: ntdll.dll + 0x71461 15:13:02 INFO - 15:13:02 INFO - PID 9568 | #01: static int mozilla::interceptor::FuncHook<mozilla::interceptor::WindowsDllInterceptor<mozilla::interceptor::VMSharingPolicyShared<mozilla::interceptor::MMPolicyInProcess,128> >,long (*)(void **, unsigned long, _OBJECT_ATTRIBUTES *, _IO_STATUS_BLOCK *, _LARGE_INTEGER *, unsigned long, unsigned long, unsigned long, unsigned long, void *, unsigned long)>::InitOnceCallback(union _RTL_RUN_ONCE *, void *, void * *) [mozglue/misc/nsWindowsDllInterceptor.h:194] 15:13:02 INFO - 15:13:02 INFO - PID 9568 | #02: ntdll.dll + 0x2285f 15:13:02 INFO - 15:13:02 INFO - PID 9568 | #03: KERNELBASE.dll + 0x539ca 15:13:02 INFO - 15:13:02 INFO - PID 9568 | #04: mozilla::InitPoisonIOInterposer() [xpcom/build/PoisonIOInterposerWin.cpp:352] 15:13:02 INFO - 15:13:02 INFO - PID 9568 | #05: mozilla::IOInterposer::Init() [xpcom/build/IOInterposer.cpp:406] 15:13:02 INFO - 15:13:02 INFO - PID 9568 | #06: XRE_InitChildProcess(int,char * * const,XREChildData const *) [toolkit/xre/nsEmbedFunctions.cpp:382] 15:13:02 INFO - 15:13:02 INFO - PID 9568 | #07: NS_internal_main(int,char * *,char * *) [browser/app/nsBrowserApp.cpp:265] 15:13:02 INFO - 15:13:02 INFO - PID 9568 | #08: wmain [toolkit/xre/nsWindowsWMain.cpp:129] 15:13:02 INFO - 15:13:02 INFO - PID 9568 | #09: static int __scrt_common_main_seh() [f:/dd/vctools/crt/vcstartup/src/startup/exe_common.inl:288] 15:13:02 INFO - 15:13:02 INFO - PID 9568 | #10: KERNEL32.DLL + 0x13034 15:13:02 INFO - 15:13:02 INFO - PID 9568 | #11: ntdll.dll + 0x71461 ``` Here is the XPC shell try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=daf79d5536f88855b4544cde827e944a59414701