Bugzilla

Thanks for the review.  It was helpful.  On a process note, some of those things I knew I needed to do, but just hadn't gotten to them yet because I was focusing on getting it working first (WIP status).  But I assume from your review that it's best to go ahead and fix those kinds of things before uploading a patch.  (After all, they might be related to the bigger problem, even if they seem unrelated.)

I've made some good progress on this, solving the main issue I had before.  Now the tasks are displayed in the main task tab and there are no more JS errors in the console (at least so far as I've poked around).

There are still glitches: no tasks showing in the today pane, you can sort by a column, but then the task labels are not correctly aligned with their tasks (tooltips don't match, opening the task opens the task in the tooltip not the one in the label, etc.).  So still WIP, more to do...

Part of what was tripping me up before was that in the XBL version there is a <tree> element that is the direct child of the "calendar-task-tree" element.  But I was trying to inherit from the MozTree custom element (following the example of the places tree CE).  So we either need to extend MozTree and not have a <tree> child, or have a <tree> child and not extend MozTree.

Since the code was written assuming a <tree> child, I've gone with that approach for now.  More things were working that way.  (Ideally I think the other way is simpler, but it probably makes sense to do that as a follow-up refactor after a successful de-xbl pass.)

Thanks for the review.  It was helpful.  On a process note, some of those things I knew I needed to do, but just hadn't gotten to them yet because I was focusing on getting it working first (WIP status).  But I assume from your review that it's best to go ahead and fix those kinds of things before uploading a patch.  (After all, they might be related to the bigger problem, even if they seem unrelated.)

I've made some good progress on this, solving the main issue I had before.  Now the tasks are displayed in the main task tab and there are no more JS errors in the console (at least so far as I've poked around).

There are still glitches: no tasks showing in the today pane, you can sort by a column, but then the task labels are not correctly aligned with their tasks (tooltips don't match, opening the task opens the task in the tooltip not the one in the label, etc.).  So still WIP, more to do...

Part of what was tripping me up before was that in the XBL version there is a <tree> element that is the direct child of the "calendar-task-tree" element.  But I was trying to inherit from the MozTree custom element (following the example of the places tree CE).  So we either need to extend MozTree and not have a <tree> child, or have a <tree> child and not extend MozTree.

Since the code was written assuming a <tree> child, I've gone with that approach for now.  More things were working that way.  (Ideally I think the other way is simpler, but it probably makes sense to do that as a follow-up refactor after a fully working de-xbl pass.)