Bug 1531844 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
0:07.18 path/to/toolkit/components/reputationservice/test/gtest/TestExecutableLists.cpp:338:1: warning: use '= delete' to prohibit calling of a special member function [modernize-use-equals-delete]
 0:07.18 TEST(TestExecutableLists, TestListExtensionsExistSomewhere) {
 0:07.18 ^
 0:07.18 path/to/opt/dist/include\gtest/gtest.h:2187:42: note: expanded from macro 'TEST'
 0:07.18 # define TEST(test_case_name, test_name) GTEST_TEST(test_case_name, test_name)
 0:07.18                                          ^
 0:07.18 path/to/opt/dist/include\gtest/gtest.h:2181:3: note: expanded from macro 'GTEST_TEST'
 0:07.18   GTEST_TEST_(test_case_name, test_name, \
 0:07.18   ^
 0:07.18 path/to/opt/dist/include\gtest/internal/gtest-internal.h:1222:7: note: expanded from macro 'GTEST_TEST_'
 0:07.18       GTEST_TEST_CLASS_NAME_(test_case_name, test_name));\
 0:07.18       ^
 0:07.18 path/to/opt/dist/include\gtest/internal/gtest-internal.h:1211:3: note: expanded from macro 'GTEST_TEST_CLASS_NAME_'
 0:07.18   test_case_name##_##test_name##_Test
 0:07.18   ^
 0:07.18 note: expanded from here


https://searchfox.org/mozilla-central/source/tools/rewriting/ThirdPartyPaths.txt lists testing/gtest/gtest/ - perhaps we need another mechanism to deal with include files copied from there or something? (copied because this is windows so no symlinks, in case that matters)
Revision 1 by
on 
```
 0:07.18 path/to/toolkit/components/reputationservice/test/gtest/TestExecutableLists.cpp:338:1: warning: use '= delete' to prohibit calling of a special member function [modernize-use-equals-delete]
 0:07.18 TEST(TestExecutableLists, TestListExtensionsExistSomewhere) {
 0:07.18 ^
 0:07.18 path/to/opt/dist/include\gtest/gtest.h:2187:42: note: expanded from macro 'TEST'
 0:07.18 # define TEST(test_case_name, test_name) GTEST_TEST(test_case_name, test_name)
 0:07.18                                          ^
 0:07.18 path/to/opt/dist/include\gtest/gtest.h:2181:3: note: expanded from macro 'GTEST_TEST'
 0:07.18   GTEST_TEST_(test_case_name, test_name, \
 0:07.18   ^
 0:07.18 path/to/opt/dist/include\gtest/internal/gtest-internal.h:1222:7: note: expanded from macro 'GTEST_TEST_'
 0:07.18       GTEST_TEST_CLASS_NAME_(test_case_name, test_name));\
 0:07.18       ^
 0:07.18 path/to/opt/dist/include\gtest/internal/gtest-internal.h:1211:3: note: expanded from macro 'GTEST_TEST_CLASS_NAME_'
 0:07.18   test_case_name##_##test_name##_Test
 0:07.18   ^
 0:07.18 note: expanded from here
```

https://searchfox.org/mozilla-central/source/tools/rewriting/ThirdPartyPaths.txt lists testing/gtest/gtest/ - perhaps we need another mechanism to deal with include files copied from there or something? (copied because this is windows so no symlinks, in case that matters)

Back to Bug 1531844 Comment 0