Dan, Are you saying this allows the user to enter a non-default clientid for an account in prefs? If so, what does the account specific pref name look like? I would assume it would look like "mail.server.serverX.clientid"? But it appears you are calling the "default" clientid "mail.default.clientid". I could be wrong but I think you need to call it "mail.server.default.clientid" like Magnus described in comment 100 for "mail.server.default.use_condstore" and comment 108 for clientid pref("mail.server.default.client_id"). Other than this, it looks good. I see you didn't have to get into any .js stuff. I will apply the patch and try to test it later today. Thanks!
Bug 1532388 Comment 116 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Dan, Are you saying this allows the user to enter a non-default clientid for an account in prefs? If so, what does the account specific pref name look like? I would assume it would look like "mail.server.serverX.clientid"? But it appears you are calling the "default" clientid "mail.default.clientid". I could be wrong but I think you need to call it "mail.server.default.clientid" like Magnus described in comment 100 for "mail.server.default.use_condstore" and comment 108 for clientid pref("mail.server.default.client_id"). Other than this, it looks good. I see you didn't have to get into any .js stuff. I will apply the patch and try to test it later today. Thanks! EDIT: Comment 117 below answers my questions.