Bug 1532640 Comment 8 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

So to elucidate this a little:

- the dialog code [lives in nsBrowserGlue.js](https://searchfox.org/mozilla-central/rev/b2d35912da5b2acecb0274eb113777d344ffb75e/browser/components/BrowserGlue.jsm#1126-1151)
- it reuses a cached `gBrowserBundle` reference to a stringbundle pointing to browser.properties
- that reference is [initialized very early on startup, when adding the builtin light/dark themes](https://searchfox.org/mozilla-central/rev/b2d35912da5b2acecb0274eb113777d344ffb75e/browser/components/BrowserGlue.jsm#1049-1053) (or perhaps earlier, I don't know).
- as far as I can tell, the reference is used for those 2 things (ie builtin theme names and safe mode dialog) as well as the post-update notification, which we only show if the update specifies a "showNotification" action (which I don't think we do much / at all anymore these days - the code looks like it's 9 years old and untouched). Those 3 are all.

A simple workaround here would be to not use the lazy getter for this dialog, and get "our own" reference to browser.properties when showing this dialog.

The slightly longer-term plan would be to add fluent-enabled prompt APIs so we can avoid using .properties bundles for this.

I expect that even if we fix this issue either of these 2 ways, the "light" and "dark" theme titles are still going to be using Swedish. Reporter, can you confirm if in about:addons and/or customize mode, the "light" theme is called "Ljus" instead of "Lyst" ?

The underlying question I have though, and don't know the answer to, is why we're ending up with a Swedish version of .properties at that point in startup. Reporter, is your Windows OS itself using Danish or Swedish, or something else?

Francesco, who knows about our startup locale negotiation?
So to elucidate this a little:

- the dialog code [lives in nsBrowserGlue.js](https://searchfox.org/mozilla-central/rev/b2d35912da5b2acecb0274eb113777d344ffb75e/browser/components/BrowserGlue.jsm#1126-1151)
- it reuses a cached `gBrowserBundle` reference to a stringbundle pointing to browser.properties
- that reference is [initialized very early on startup, when adding the builtin light/dark themes](https://searchfox.org/mozilla-central/rev/b2d35912da5b2acecb0274eb113777d344ffb75e/browser/components/BrowserGlue.jsm#1049-1053).
- as far as I can tell, the reference is used for those 2 things (ie builtin theme names and safe mode dialog) as well as the post-update notification, which we only show if the update specifies a "showNotification" action (which I don't think we do much / at all anymore these days - the code looks like it's 9 years old and untouched). Those 3 are all.

A simple workaround here would be to not use the lazy getter for this dialog, and get "our own" reference to browser.properties when showing this dialog.

The slightly longer-term plan would be to add fluent-enabled prompt APIs so we can avoid using .properties bundles for this.

I expect that even if we fix this issue either of these 2 ways, the "light" and "dark" theme titles are still going to be using Swedish. Reporter, can you confirm if in about:addons and/or customize mode, the "light" theme is called "Ljus" instead of "Lyst" ?

The underlying question I have though, and don't know the answer to, is why we're ending up with a Swedish version of .properties at that point in startup. Reporter, is your Windows OS itself using Danish or Swedish, or something else?

Francesco, who knows about our startup locale negotiation?

Back to Bug 1532640 Comment 8