Bugzilla

Hi Max,


> Hi Mark,
> 
> I removed dom/xhr/** line in step a.
> In step b, I ran `./mach eslint --fix dom/xhr`. I got a lot of errors.
> What do you mean by 'This should fix some of the issues'?
> From here, do I continue to step c and d, or fix the errors and then move on?



 
After `./mach eslint --fix dom/xhr` you can check some changes happened with `hg diff` and you need to commit them with the commit message mentioned in `Step D` and after that rest of the errors you are getting you need to solve manually one by one and then commit them with the commit message mentioned in `Step F`. You can check the errors by running `./mach eslint dom/xhr` at root of the cloned source code. Let us know if you need more help.

Hi Max,


> Hi Mark,
> 
> I removed dom/xhr/** line in step a.
> In step b, I ran `./mach eslint --fix dom/xhr`. I got a lot of errors.
> What do you mean by 'This should fix some of the issues'?
> From here, do I continue to step c and d, or fix the errors and then move on?



Yes you need to continue with Steps C and D.

 
After `./mach eslint --fix dom/xhr` you can check some changes happened with `hg diff` and you need to commit them with the commit message mentioned in `Step D` and after that rest of the errors you are getting you need to solve manually one by one and then commit them with the commit message mentioned in `Step F`. You can check the errors by running `./mach eslint dom/xhr` at root of the cloned source code. Let us know if you need more help.

Hi Max,


> I removed dom/xhr/** line in step a.
> In step b, I ran `./mach eslint --fix dom/xhr`. I got a lot of errors.
> What do you mean by 'This should fix some of the issues'?
> From here, do I continue to step c and d, or fix the errors and then move on?



Yes you need to continue with Steps C and D.

 
After `./mach eslint --fix dom/xhr` you can check some changes happened with `hg diff` and you need to commit them with the commit message mentioned in `Step D` and after that rest of the errors you are getting you need to solve manually one by one and then commit them with the commit message mentioned in `Step F`. You can check the errors by running `./mach eslint dom/xhr` at root of the cloned source code. Let us know if you need more help.