Bug 1533002 Comment 6 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
Looking more into this, I believe Sarah actually address this bug entirely, thanks to 1603249.
Am I correct on this?
Revision 1 by
on 
Looking more into this, I believe Sarah actually address this bug entirely *including* the proper error handling, thanks to 1603249.
Am I correct on this?
Revision 2 by
on 
Looking more into this, I believe Sarah actually address this bug entirely *including* the proper error handling, thanks to bug 1603249 and the associated PR which made [these specific changes](https://github.com/mozilla/treeherder/blob/77bf3ab9a2d159f46b2d1c922e27471d1602aea8/ui/perfherder/compare/ReplicatesGraph.jsx#L74-L84):

```javascript
const replicatePromises = perfDatum.job_ids.map(jobId =>
      getReplicateData({ jobId, rootUrl: project.tc_root_url }),
    );

    const localReplicateData = await Promise.all(replicatePromises);
    const errorMessages = processErrors(localReplicateData);

    if (errorMessages.length) {
      replicateData.replicateDataError = true;
      return { replicateData };
    }
```

Am I correct on this?
Revision 3 by
on 
Looking more into this, I believe Sarah actually addressed this bug entirely *including* the proper error handling, thanks to bug 1603249 and the associated PR which made [these specific changes](https://github.com/mozilla/treeherder/blob/77bf3ab9a2d159f46b2d1c922e27471d1602aea8/ui/perfherder/compare/ReplicatesGraph.jsx#L74-L84):

```javascript
const replicatePromises = perfDatum.job_ids.map(jobId =>
      getReplicateData({ jobId, rootUrl: project.tc_root_url }),
    );

    const localReplicateData = await Promise.all(replicatePromises);
    const errorMessages = processErrors(localReplicateData);

    if (errorMessages.length) {
      replicateData.replicateDataError = true;
      return { replicateData };
    }
```

Am I correct on this?

Back to Bug 1533002 Comment 6