Opening the filtered subdialog in about:preferences#privacy is a lot more work and more risky than opening the dialog window (what I proposed in comment 0 and comment 10) so I don't think we should rush that into 67. I also have concerns about the tab switching as we currently "switch-to-tab" when opening about:preferences meaning that if an existing about:preferences tab is open then we will switch to that tab (which may be far away from the tab the user was on if they have many tabs) and re-use it. We would have to pass the dialog to open, the domain to filter, along with the section of about:preferences to select. All of this would be avoided if we use the existing pattern of opening the dialog in its own window.
Bug 1534447 Comment 17 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Opening the filtered subdialog in about:preferences#privacy is a lot more work and more risky than opening the dialog window (what I proposed in comment 0 and comment 10) so I don't think we should rush that into 67. I also have concerns about the tab switching as we currently "switch-to-tab" when opening about:preferences meaning that if an existing about:preferences tab is open then we will switch to that tab (which may be far away from the tab the user was on if they have many tabs) and re-use it. We would have to pass the dialog to open, the domain to filter, along with the section of about:preferences to select. All of this would be avoided if we use the existing pattern of opening the dialog in its own window, at least for now.
Opening the filtered subdialog in about:preferences#privacy is a lot more work and more risky than opening the dialog window (what I proposed in comment 0 and comment 10) so I don't think we should rush that into 67. I also have concerns about the tab switching as we currently "switch-to-tab" when opening about:preferences meaning that if an existing about:preferences tab is open then we will switch to that tab (which may be far away from the tab the user was on if they have many tabs) and re-use it. We would have to pass the dialog to open, the domain to filter, along with the section of about:preferences to select. All of this would be avoided if we use the existing pattern of opening the dialog in its own window, at least for now. It doesn't seem worthwhile to put all the effort into deeplinking to a subdialog when Lockbox will replace this within the year.