Review of attachment 9059112 [details] [diff] [review]: ----------------------------------------------------------------- OK, checking what I have forgotten. ::: calendar/base/content/dialogs/calendar-event-dialog-recurrence.js @@ +70,5 @@ > const cWidth = containerWidth % contentWidth; > let numHorizontal = (containerWidth - cWidth) / contentWidth; > > + let contentHeight = minimonth.getBoundingClientRect().height; > + let containerHeight = this.node.getBoundingClientRect().height; Forgot to fix this. ::: mail/base/content/mailWidgets.xml @@ +151,5 @@ > // ... or not far enough? > + else if (item.screenY + item.getBoundingClientRect().height > > + box.screenY + box.getBoundingClientRect().height) > + box.scrollTop = item.getBoundingClientRect().y + item.getBoundingClientRect().height - > + box.getBoundingClientRect().y - box.getBoundingClientRect().height; More here. ::: mail/base/content/sanitizeDialog.js @@ +80,5 @@ > } > > // If clearing a specific time range > if (!warningBox.hidden) { > + window.resizeBy(0, -warningBox.getBoundingClientRect().height); Here. ::: mail/base/content/tabmail.xml @@ +2304,3 @@ > return null; > > + if (event.screenX > tab.screenX + tab.getBoundingClientRect().width * .75) Here. @@ +2322,4 @@ > return i; > } else { > for (let i = 0; i < tabs.length; i++) > + if (event.screenX > (tabs[i].screenX + (tabs[i].getBoundingClientRect().width / 2))) Here. ::: mail/base/modules/GlobalPopupNotifications.jsm @@ +833,5 @@ > this._refreshPanel(notificationsToShow); > > // If the anchor element is hidden or null, fall back to the identity icon. > + if (!anchorElement || (anchorElement.getBoundingClientRect().height == 0 && > + anchorElement.getBoundingClientRect().width == 0)) { Here and twice below. ::: mail/components/compose/content/MsgComposeCommands.js @@ +5657,5 @@ > let bucket = document.getElementById("attachmentBucket"); > > if (target == bucket) { > // Dragging or dropping at top/bottom border of the listbox > + if ((aEvent.screenY - target.screenY) / target.getBoundingClientRect().height < 0.5) { Here and twice below. ::: mail/components/compose/content/addressingWidgetOverlay.js @@ +65,2 @@ > > + msgHeadersToolbar.height = msgHeadersToolbar.getBoundingClientRect().height + Here. ::: mail/test/mozmill/folder-display/test-opening-messages.js @@ +193,5 @@ > let childrenHeightsStr = ""; > for (let child of messengerChildren) { > if ("boxObject" in child) { > + childrenHeightsSum += child.getBoundingClientRect().height; > + childrenHeightsStr += '"' + child.id + '": ' + child.getBoundingClientRect().height + ', '; Here. ::: mail/test/mozmill/shared-modules/test-folder-display-helpers.js @@ +1095,5 @@ > aTree.focus(); > // very important, gotta be able to see the row > aTree.ensureRowIsVisible(aViewIndex); > // coordinates of the upper left of the entire tree widget (headers included) > + let tx = aTree.getBoundingClientRect().x, ty = aTree.getBoundingClientRect().y; Here and twice below. ::: mail/test/mozmill/shared-modules/test-mouse-event-helpers.js @@ +58,5 @@ > synthesize_drop(aDropWindow, aDropObject, dt, > + { screenX : aDropObject.screenX + > + (aDropObject.getBoundingClientRect().width * aRelDropX), > + screenY : aDropObject.screenY + > + (aDropObject.getBoundingClientRect().width * aRelDropY) Here. ::: mail/test/mozmill/tabmail/test-tabmail-dragndrop.js @@ +235,5 @@ > > // notify tab1 drag has ended > synthesize_drag_end(mc.window, dropContent, tab1, dt, > + { screenX : (dropContent.screenX + dropContent.getBoundingClientRect().width / 2 ), > + screenY : (dropContent.screenY + dropContent.getBoundingClientRect().height / 2 ) }); Here.
Bug 1535725 Comment 27 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Review of attachment 9059112 [details] [diff] [review]: ----------------------------------------------------------------- OK, checking what I have forgotten. ::: calendar/base/content/dialogs/calendar-event-dialog-recurrence.js @@ +70,5 @@ > const cWidth = containerWidth % contentWidth; > let numHorizontal = (containerWidth - cWidth) / contentWidth; > > + let contentHeight = minimonth.getBoundingClientRect().height; > + let containerHeight = this.node.getBoundingClientRect().height; Forgot to fix this. ::: mail/base/content/mailWidgets.xml @@ +151,5 @@ > // ... or not far enough? > + else if (item.screenY + item.getBoundingClientRect().height > > + box.screenY + box.getBoundingClientRect().height) > + box.scrollTop = item.getBoundingClientRect().y + item.getBoundingClientRect().height - > + box.getBoundingClientRect().y - box.getBoundingClientRect().height; More here. ::: mail/base/content/sanitizeDialog.js @@ +80,5 @@ > } > > // If clearing a specific time range > if (!warningBox.hidden) { > + window.resizeBy(0, -warningBox.getBoundingClientRect().height); Here. EDIT: No saving here. ::: mail/base/content/tabmail.xml @@ +2304,3 @@ > return null; > > + if (event.screenX > tab.screenX + tab.getBoundingClientRect().width * .75) Here. @@ +2322,4 @@ > return i; > } else { > for (let i = 0; i < tabs.length; i++) > + if (event.screenX > (tabs[i].screenX + (tabs[i].getBoundingClientRect().width / 2))) Here. ::: mail/base/modules/GlobalPopupNotifications.jsm @@ +833,5 @@ > this._refreshPanel(notificationsToShow); > > // If the anchor element is hidden or null, fall back to the identity icon. > + if (!anchorElement || (anchorElement.getBoundingClientRect().height == 0 && > + anchorElement.getBoundingClientRect().width == 0)) { Here and twice below. ::: mail/components/compose/content/MsgComposeCommands.js @@ +5657,5 @@ > let bucket = document.getElementById("attachmentBucket"); > > if (target == bucket) { > // Dragging or dropping at top/bottom border of the listbox > + if ((aEvent.screenY - target.screenY) / target.getBoundingClientRect().height < 0.5) { Here and twice below. ::: mail/components/compose/content/addressingWidgetOverlay.js @@ +65,2 @@ > > + msgHeadersToolbar.height = msgHeadersToolbar.getBoundingClientRect().height + Here. ::: mail/test/mozmill/folder-display/test-opening-messages.js @@ +193,5 @@ > let childrenHeightsStr = ""; > for (let child of messengerChildren) { > if ("boxObject" in child) { > + childrenHeightsSum += child.getBoundingClientRect().height; > + childrenHeightsStr += '"' + child.id + '": ' + child.getBoundingClientRect().height + ', '; Here. ::: mail/test/mozmill/shared-modules/test-folder-display-helpers.js @@ +1095,5 @@ > aTree.focus(); > // very important, gotta be able to see the row > aTree.ensureRowIsVisible(aViewIndex); > // coordinates of the upper left of the entire tree widget (headers included) > + let tx = aTree.getBoundingClientRect().x, ty = aTree.getBoundingClientRect().y; Here and twice below. ::: mail/test/mozmill/shared-modules/test-mouse-event-helpers.js @@ +58,5 @@ > synthesize_drop(aDropWindow, aDropObject, dt, > + { screenX : aDropObject.screenX + > + (aDropObject.getBoundingClientRect().width * aRelDropX), > + screenY : aDropObject.screenY + > + (aDropObject.getBoundingClientRect().width * aRelDropY) Here. ::: mail/test/mozmill/tabmail/test-tabmail-dragndrop.js @@ +235,5 @@ > > // notify tab1 drag has ended > synthesize_drag_end(mc.window, dropContent, tab1, dt, > + { screenX : (dropContent.screenX + dropContent.getBoundingClientRect().width / 2 ), > + screenY : (dropContent.screenY + dropContent.getBoundingClientRect().height / 2 ) }); Here.
Review of attachment 9059112 [details] [diff] [review]: ----------------------------------------------------------------- OK, checking what I have forgotten. ::: calendar/base/content/dialogs/calendar-event-dialog-recurrence.js @@ +70,5 @@ > const cWidth = containerWidth % contentWidth; > let numHorizontal = (containerWidth - cWidth) / contentWidth; > > + let contentHeight = minimonth.getBoundingClientRect().height; > + let containerHeight = this.node.getBoundingClientRect().height; Forgot to fix this. ::: mail/base/content/mailWidgets.xml @@ +151,5 @@ > // ... or not far enough? > + else if (item.screenY + item.getBoundingClientRect().height > > + box.screenY + box.getBoundingClientRect().height) > + box.scrollTop = item.getBoundingClientRect().y + item.getBoundingClientRect().height - > + box.getBoundingClientRect().y - box.getBoundingClientRect().height; More here. ::: mail/base/content/sanitizeDialog.js @@ +80,5 @@ > } > > // If clearing a specific time range > if (!warningBox.hidden) { > + window.resizeBy(0, -warningBox.getBoundingClientRect().height); Here. EDIT: No saving here. ::: mail/base/content/tabmail.xml @@ +2304,3 @@ > return null; > > + if (event.screenX > tab.screenX + tab.getBoundingClientRect().width * .75) Here. @@ +2322,4 @@ > return i; > } else { > for (let i = 0; i < tabs.length; i++) > + if (event.screenX > (tabs[i].screenX + (tabs[i].getBoundingClientRect().width / 2))) Here. EDIT: No saving here. ::: mail/base/modules/GlobalPopupNotifications.jsm @@ +833,5 @@ > this._refreshPanel(notificationsToShow); > > // If the anchor element is hidden or null, fall back to the identity icon. > + if (!anchorElement || (anchorElement.getBoundingClientRect().height == 0 && > + anchorElement.getBoundingClientRect().width == 0)) { Here and twice below. ::: mail/components/compose/content/MsgComposeCommands.js @@ +5657,5 @@ > let bucket = document.getElementById("attachmentBucket"); > > if (target == bucket) { > // Dragging or dropping at top/bottom border of the listbox > + if ((aEvent.screenY - target.screenY) / target.getBoundingClientRect().height < 0.5) { Here and twice below. ::: mail/components/compose/content/addressingWidgetOverlay.js @@ +65,2 @@ > > + msgHeadersToolbar.height = msgHeadersToolbar.getBoundingClientRect().height + Here. ::: mail/test/mozmill/folder-display/test-opening-messages.js @@ +193,5 @@ > let childrenHeightsStr = ""; > for (let child of messengerChildren) { > if ("boxObject" in child) { > + childrenHeightsSum += child.getBoundingClientRect().height; > + childrenHeightsStr += '"' + child.id + '": ' + child.getBoundingClientRect().height + ', '; Here. ::: mail/test/mozmill/shared-modules/test-folder-display-helpers.js @@ +1095,5 @@ > aTree.focus(); > // very important, gotta be able to see the row > aTree.ensureRowIsVisible(aViewIndex); > // coordinates of the upper left of the entire tree widget (headers included) > + let tx = aTree.getBoundingClientRect().x, ty = aTree.getBoundingClientRect().y; Here and twice below. ::: mail/test/mozmill/shared-modules/test-mouse-event-helpers.js @@ +58,5 @@ > synthesize_drop(aDropWindow, aDropObject, dt, > + { screenX : aDropObject.screenX + > + (aDropObject.getBoundingClientRect().width * aRelDropX), > + screenY : aDropObject.screenY + > + (aDropObject.getBoundingClientRect().width * aRelDropY) Here. ::: mail/test/mozmill/tabmail/test-tabmail-dragndrop.js @@ +235,5 @@ > > // notify tab1 drag has ended > synthesize_drag_end(mc.window, dropContent, tab1, dt, > + { screenX : (dropContent.screenX + dropContent.getBoundingClientRect().width / 2 ), > + screenY : (dropContent.screenY + dropContent.getBoundingClientRect().height / 2 ) }); Here.
Review of attachment 9059112 [details] [diff] [review]: ----------------------------------------------------------------- OK, checking what I have forgotten. ::: calendar/base/content/dialogs/calendar-event-dialog-recurrence.js @@ +70,5 @@ > const cWidth = containerWidth % contentWidth; > let numHorizontal = (containerWidth - cWidth) / contentWidth; > > + let contentHeight = minimonth.getBoundingClientRect().height; > + let containerHeight = this.node.getBoundingClientRect().height; Forgot to fix this. ::: mail/base/content/mailWidgets.xml @@ +151,5 @@ > // ... or not far enough? > + else if (item.screenY + item.getBoundingClientRect().height > > + box.screenY + box.getBoundingClientRect().height) > + box.scrollTop = item.getBoundingClientRect().y + item.getBoundingClientRect().height - > + box.getBoundingClientRect().y - box.getBoundingClientRect().height; More here. ::: mail/base/content/sanitizeDialog.js @@ +80,5 @@ > } > > // If clearing a specific time range > if (!warningBox.hidden) { > + window.resizeBy(0, -warningBox.getBoundingClientRect().height); Here. EDIT: No saving here. ::: mail/base/content/tabmail.xml @@ +2304,3 @@ > return null; > > + if (event.screenX > tab.screenX + tab.getBoundingClientRect().width * .75) Here. @@ +2322,4 @@ > return i; > } else { > for (let i = 0; i < tabs.length; i++) > + if (event.screenX > (tabs[i].screenX + (tabs[i].getBoundingClientRect().width / 2))) Here. EDIT: No saving here. ::: mail/base/modules/GlobalPopupNotifications.jsm @@ +833,5 @@ > this._refreshPanel(notificationsToShow); > > // If the anchor element is hidden or null, fall back to the identity icon. > + if (!anchorElement || (anchorElement.getBoundingClientRect().height == 0 && > + anchorElement.getBoundingClientRect().width == 0)) { Here and twice below. ::: mail/components/compose/content/MsgComposeCommands.js @@ +5657,5 @@ > let bucket = document.getElementById("attachmentBucket"); > > if (target == bucket) { > // Dragging or dropping at top/bottom border of the listbox > + if ((aEvent.screenY - target.screenY) / target.getBoundingClientRect().height < 0.5) { Here and twice below. EDIT: No saving here. ::: mail/components/compose/content/addressingWidgetOverlay.js @@ +65,2 @@ > > + msgHeadersToolbar.height = msgHeadersToolbar.getBoundingClientRect().height + Here. ::: mail/test/mozmill/folder-display/test-opening-messages.js @@ +193,5 @@ > let childrenHeightsStr = ""; > for (let child of messengerChildren) { > if ("boxObject" in child) { > + childrenHeightsSum += child.getBoundingClientRect().height; > + childrenHeightsStr += '"' + child.id + '": ' + child.getBoundingClientRect().height + ', '; Here. ::: mail/test/mozmill/shared-modules/test-folder-display-helpers.js @@ +1095,5 @@ > aTree.focus(); > // very important, gotta be able to see the row > aTree.ensureRowIsVisible(aViewIndex); > // coordinates of the upper left of the entire tree widget (headers included) > + let tx = aTree.getBoundingClientRect().x, ty = aTree.getBoundingClientRect().y; Here and twice below. ::: mail/test/mozmill/shared-modules/test-mouse-event-helpers.js @@ +58,5 @@ > synthesize_drop(aDropWindow, aDropObject, dt, > + { screenX : aDropObject.screenX + > + (aDropObject.getBoundingClientRect().width * aRelDropX), > + screenY : aDropObject.screenY + > + (aDropObject.getBoundingClientRect().width * aRelDropY) Here. ::: mail/test/mozmill/tabmail/test-tabmail-dragndrop.js @@ +235,5 @@ > > // notify tab1 drag has ended > synthesize_drag_end(mc.window, dropContent, tab1, dt, > + { screenX : (dropContent.screenX + dropContent.getBoundingClientRect().width / 2 ), > + screenY : (dropContent.screenY + dropContent.getBoundingClientRect().height / 2 ) }); Here.