Bug 1538151 Comment 14 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

When(In reply to Steven MacLeod [:smacleod] from comment #4)
> This actually appears to be an upstream Phabricator bug. It looks like Phabricator is considering the currently authenticated user uploading the diff as the "author", when it should be using the real author of the revision. Phabricator itself needs to change to pull the author from the proper spot.
> 
> Until this happens the workaround is to make sure you're not attempting to set yourself as a reviewer using moz-phab (so removing r=<username> from the message as padenot indicated).

Hi all,
I just had this exact problem, indeed it seems that Phabricator considers the submitter to be the author of the commit, which is a problem.
I tried both with moz-phab with r=bbeurdouche and manually setting the reviewer in Phabricator, both ended with the error:
"The author of a revision can not be a reviewer".
When(In reply to Steven MacLeod [:smacleod] from comment #4)
> This actually appears to be an upstream Phabricator bug. It looks like Phabricator is considering the currently authenticated user uploading the diff as the "author", when it should be using the real author of the revision. Phabricator itself needs to change to pull the author from the proper spot.
> 
> Until this happens the workaround is to make sure you're not attempting to set yourself as a reviewer using moz-phab (so removing r=<username> from the message as padenot indicated).

Hi all,
I just had this exact problem, indeed it seems that Phabricator considers the submitter to be the author of the commit, might be a problem in certain cases.
I tried both with moz-phab with r=bbeurdouche and manually setting the reviewer in Phabricator, both ended with the error:
"The author of a revision can not be a reviewer".

Back to Bug 1538151 Comment 14