(In reply to Wayne Mery (:wsmwk) from comment #2) > ready for review? I am not sure what we want to about this. My take on this is that: - there was a time when an invalid URI is passed as I mentioned in the original post. (I am not sure how it is. I suppose it still *IS* the case) - A surprise: M-C seems to have REMOVED the CHECK (!?) Sure this REMOVES the error/warning in debug build. *HOWEVER* I think this is a *BOGUS* change, and frankly I want to know the reason behind such a change. There were/are places where invalid URLs were passed around and the code elsewhere either did not check or written in a loose manner that it works by chance, but maybe it is not doing exactly what the original author intended.
Bug 1539997 Comment 3 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
(In reply to Wayne Mery (:wsmwk) from comment #2) > ready for review? I am not sure what we want to about this. My take on this is that: - there was a time when an invalid URI is passed as I mentioned in the original post. (I am not sure how it is. I suppose it still **IS** the case) - A surprise: M-C seems to have **REMOVED the CHECK (!?)** Sure this REMOVES the error/warning in debug build. **HOWEVER** I think this is a **BOGUS** change, and frankly I want to know the reason behind such a change. There were/are places where invalid URLs were passed around and the code elsewhere either did not check or written in a loose manner that it works by chance, but maybe it is not doing exactly what the original author intended.
(In reply to Wayne Mery (:wsmwk) from comment #2) > ready for review? I am not sure what we want to about this. My take on this is that: - there was a time when invalid URLs were passed as I mentioned in the original post. (I am not sure how it is. I suppose it still **IS** the case) - A surprise: M-C seems to have **REMOVED the CHECK (!?)** Sure this REMOVES the error/warning in debug build. **HOWEVER** I think this is a **BOGUS** change, and frankly I want to know the reason behind such a change. There were/are places where invalid URLs were passed around and the code elsewhere either did not check or is written in a loose manner that it works by chance, but maybe it is not doing exactly what the original author intended.
(In reply to Wayne Mery (:wsmwk) from comment #2) > ready for review? I am not sure what we want to about this. My take on this is that: - there was a time when invalid URIs were passed as I mentioned in the original post. (I am not sure how it is. I suppose it still **IS** the case) - A surprise: M-C seems to have **REMOVED the CHECK (!?)** Sure this REMOVES the error/warning in debug build. **HOWEVER** I think this is a **BOGUS** change, and frankly I want to know the reason behind such a change. There were/are places where invalid URIs were passed around and the code elsewhere either did not check or is written in a loose manner that it works by chance, but maybe it is not doing exactly what the original author intended.