Bug 1543059 Comment 6 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

It looks like this is happening during changing the ready state and not detecting the media as ended[0]. This happens because we have `mDecoder` and that decoder is not reporting that it's ended[1, 2].

It looks like the decoder moves to the ended state following us firing the notification rather than before, which would avoid this bug.

Regression range https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=5eba13f5b3a6ad80decdd8c7b30bff5fa477844f&tochange=2ed5e7fbf39e949693d8a7455d6313b14a7aeaf6

[0] https://searchfox.org/mozilla-central/rev/0c682c4f01442c3de0fa6cd286e9cadc8276b45f/dom/html/HTMLMediaElement.cpp#6074
[1] https://searchfox.org/mozilla-central/rev/0c682c4f01442c3de0fa6cd286e9cadc8276b45f/dom/html/HTMLMediaElement.cpp#2184
[2] https://searchfox.org/mozilla-central/rev/0c682c4f01442c3de0fa6cd286e9cadc8276b45f/dom/media/MediaDecoder.cpp#797
It looks like this is happening during changing the ready state and not detecting the media as ended[0]. This happens because we have `mDecoder` and that decoder is not reporting that it's ended[1, 2].

It looks like the decoder moves to the ended state following us firing the notification rather than before, which would avoid this bug.

Regression range (edit): derp, missed it in comment 0 after coming back to this.

[0] https://searchfox.org/mozilla-central/rev/0c682c4f01442c3de0fa6cd286e9cadc8276b45f/dom/html/HTMLMediaElement.cpp#6074
[1] https://searchfox.org/mozilla-central/rev/0c682c4f01442c3de0fa6cd286e9cadc8276b45f/dom/html/HTMLMediaElement.cpp#2184
[2] https://searchfox.org/mozilla-central/rev/0c682c4f01442c3de0fa6cd286e9cadc8276b45f/dom/media/MediaDecoder.cpp#797

Back to Bug 1543059 Comment 6