Bug 1543773 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Follow up an issue I discovered when working on Bug 1529992, but wasn't immediately clear to me how to handle. I will be checking in layout/reftests/bugs/1529992-2.html as fails-if(webrender), which demonstrates the problem.

text-shadows that are applied in the ::selection or ::inactive-selection pseudo-selector should be clipped to the bounds of the display item's selection, but this doesn't currently happen with webrender. Not yet sure where exactly this clipping is applied, and why we're missing it (I expect it's being attached to the PushShadow as a rect, which WR currently ignores).

It's a pretty niche issue, and when done correctly it creates ugly results (cut off shadows), so I don't think fixing this should be a very high priority. That said, it's a regression from non-wr, and chrome/safari also implement it (although safari has really bad invalidation bugs with selection shadows).
Follow up bug for an issue I discovered when working on Bug 1529992, but wasn't immediately clear to me how to handle. I will be checking in layout/reftests/bugs/1529992-2.html as fails-if(webrender), which demonstrates the problem.

text-shadows that are applied in the ::selection or ::inactive-selection pseudo-selector should be clipped to the bounds of the display item's selection, but this doesn't currently happen with webrender. Not yet sure where exactly this clipping is applied, and why we're missing it (I expect it's being attached to the PushShadow as a rect, which WR currently ignores).

It's a pretty niche issue, and when done correctly it creates ugly results (cut off shadows), so I don't think fixing this should be a very high priority. That said, it's a regression from non-wr, and chrome/safari also implement it (although safari has really bad invalidation bugs with selection shadows).

Back to Bug 1543773 Comment 0