Thanks, Dale. I see that Amazon, Google and Wikipedia also have icons now, Yandex doesn't, looks like there are two (yandex-en, yandex-ru), both referenced in the JSON file. No problem to move them manually. I'm just wondering how to proceed best here. Take the ZIP file as a base or worry about the "firefox" replacement first and then migrate again. It will be easier to drop single lines from the XML files than to edit them out of the JSON files. We have something like `<Param name="sourceid" value="firefox"/>` 13 times and then five other ones (see comment #27): ``` google.xml:<Url type="application/x-suggestions+json" method="GET" template="https://www.google.com/complete/search?client=firefox&q={searchTerms}"/> heureka-cz.xml:<Url type="application/x-suggestions+json" method="GET" template="https://www.heureka.cz/direct/firefox/autocompleter.php"> olx.xml:<Url type="application/x-suggestions+json" method="GET" template="http://www.olx.ba/sugestije/firefox_pojmovi"> osta-ee.xml:<Url type="text/html" method="GET" template="http://www.osta.ee/firefox/" resultdomain="osta.ee"> priberam.xml:<Url type="text/html" method="GET" template="http://www.priberam.pt/dlpo/firefox.aspx" resultdomain="priberam.pt"> ``` where the "firefox" is part of a URL. So let's phrase this quite clearly for Mike to answer: Mike, in bug 1427133 we copied the search engine XML files from FF, made some edits (summarised in comment #21) and landed the whole thing here: https://hg.mozilla.org/comm-central/rev/1337b98ae249 As a result, we now have the string "firefox" 18 times in our XML files, 13 files as `Param`, and five times as part of the URL, see above in this comment. Before we migrate the XML files to WebExtension JSON files, should we clean up the "firefox" strings? The 13 `Param`s can be easily dropped. The five other ones are not so easily treatable. Apart from `client=firefox`, the remaining four specify a path on the search engine server, so removing "firefox" there will break things.
Bug 1544013 Comment 32 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Thanks, Dale. I see that Amazon, Google and Wikipedia also have icons now, Yandex doesn't, looks like there are two (yandex-en, yandex-ru), both referenced in the JSON file. No problem to move them manually. I'm just wondering how to proceed best here. Take the ZIP file as a base or worry about the "firefox" replacement first and then migrate again. It will be easier to drop single lines from the XML files than to edit them out of the JSON files. We have something like `<Param name="sourceid" value="firefox"/>` 13 times and then five other ones (see comment #27): ``` google.xml:<Url type="application/x-suggestions+json" method="GET" template="https://www.google.com/complete/search?client=firefox&q={searchTerms}"/> heureka-cz.xml:<Url type="application/x-suggestions+json" method="GET" template="https://www.heureka.cz/direct/firefox/autocompleter.php"> olx.xml:<Url type="application/x-suggestions+json" method="GET" template="http://www.olx.ba/sugestije/firefox_pojmovi"> osta-ee.xml:<Url type="text/html" method="GET" template="http://www.osta.ee/firefox/" resultdomain="osta.ee"> priberam.xml:<Url type="text/html" method="GET" template="http://www.priberam.pt/dlpo/firefox.aspx" resultdomain="priberam.pt"> ``` where the "firefox" is part of a URL. So let's phrase this quite clearly for Mike to answer: Mike, in bug 1427133 we copied the search engine XML files from FF, made some edits (summarised in comment #21) and landed the whole thing here: https://hg.mozilla.org/comm-central/rev/1337b98ae249 As a result, we now have the string "firefox" 18 times in our XML files, 13 files as `Param`, and five times as part of the URL, see above in this comment. Before we migrate the XML files to WebExtension JSON files, should we clean up the "firefox" strings? The 13 `Param`s can be easily dropped. The five other ones are not so easily treatable. Apart from `client=firefox`, the remaining four specify a path on the search engine server, so removing "firefox" there will break things. EDIT: I tried it, the Google search stops working when removing `client=firefox`, so all I could do for the clean-up would be to remove the 13 occurrences of "firefox" in a `Param`.
Thanks, Dale. I see that Amazon, Google and Wikipedia also have icons now, Yandex doesn't, looks like there are two (yandex-en, yandex-ru), both referenced in the JSON file. No problem to move them manually. I'm just wondering how to proceed best here. Take the ZIP file as a base or worry about the "firefox" replacement first and then migrate again. It will be easier to drop single lines from the XML files than to edit them out of the JSON files. We have something like `<Param name="sourceid" value="firefox"/>` 15 times and then five other ones (see comment #27): ``` google.xml:<Url type="application/x-suggestions+json" method="GET" template="https://www.google.com/complete/search?client=firefox&q={searchTerms}"/> heureka-cz.xml:<Url type="application/x-suggestions+json" method="GET" template="https://www.heureka.cz/direct/firefox/autocompleter.php"> olx.xml:<Url type="application/x-suggestions+json" method="GET" template="http://www.olx.ba/sugestije/firefox_pojmovi"> osta-ee.xml:<Url type="text/html" method="GET" template="http://www.osta.ee/firefox/" resultdomain="osta.ee"> priberam.xml:<Url type="text/html" method="GET" template="http://www.priberam.pt/dlpo/firefox.aspx" resultdomain="priberam.pt"> ``` where the "firefox" is part of a URL. So let's phrase this quite clearly for Mike to answer: Mike, in bug 1427133 we copied the search engine XML files from FF, made some edits (summarised in comment #21) and landed the whole thing here: https://hg.mozilla.org/comm-central/rev/1337b98ae249 As a result, we now have the string "firefox" 20 times in our XML files, 15 files as `Param`, and five times as part of the URL, see above in this comment. Before we migrate the XML files to WebExtension JSON files, should we clean up the "firefox" strings? The 15 `Param`s can be easily dropped. The five other ones are not so easily treatable. Apart from `client=firefox`, the remaining four specify a path on the search engine server, so removing "firefox" there will break things. EDIT: I tried it, the Google search stops working when removing `client=firefox`, so all I could do for the clean-up would be to remove the 15 occurrences of "firefox" in a `Param`.