Bug 1546336 Comment 3 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Magnus Melin [:mkmelin] from comment #2)
> Comment on attachment 9072505 [details] [diff] [review]
> Bug-1546336_de-xbl_toolbar-menubar-autohide.patch
> 
> Review of attachment 9072505 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> The build complains about there no longer being any preprocessing in the
> bindings.css file. So you should remove the star from
> https://searchfox.org/comm-central/source/mail/base/jar.mn#43 (which means
> preprocess this file)

Okay, Cool.

> 
> Can we put the file in mail/base/content/messenger-customization.js to match
> up with firefox?

Yeah, sure.

> Doesn't seem to work though. If I right click the toolbar and uncheck the
> menu bar, the menu bar still shows. That's what this binding is about, isn't
> it?

Yes, I checked on Linux Machine and it was working. I will check again.
(In reply to Magnus Melin [:mkmelin] from comment #2)

> 
> The build complains about there no longer being any preprocessing in the
> bindings.css file. So you should remove the star from
> https://searchfox.org/comm-central/source/mail/base/jar.mn#43 (which means
> preprocess this file)

Okay, Cool.

> 
> Can we put the file in mail/base/content/messenger-customization.js to match
> up with firefox?

Yeah, sure.

> Doesn't seem to work though. If I right click the toolbar and uncheck the
> menu bar, the menu bar still shows. That's what this binding is about, isn't
> it?

Yes, I checked on Linux Machine and it was working. I will check again.

Back to Bug 1546336 Comment 3