(In reply to Magnus Melin [:mkmelin] from comment #24) > For figuring out where calls come from, often putting a console.trace() at the interesting place will help a bunch. Thanks, yeah, I've been using console.trace when I can't get the debugger working. It's how I got the log above. But if I put a console.trace() in the startOfWeek call I don't get any more info about how we get from JSON.stringify(first) in the test to the startOfWeek call: ``` console.trace: 0:12.96 pid:24864 resource://calendar/calendar-js/calDateTime.js 167 get startOfWeek 0:12.96 pid:24864 [...]/xpcshell/comm/calendar/test/unit/test_caldav_requests.js 903 test_freebusy_request 0:12.96 pid:24864 [...]/xpcshell/head.js 1567 run_next_test/_run_next_test/< 0:12.96 pid:24864 [...]/xpcshell/head.js 1567 _run_next_test 0:12.96 pid:24864 [...]/xpcshell/head.js 735 run 0:12.96 pid:24864 [...]/xpcshell/head.js 246 _do_main 0:12.96 pid:24864 [...]/xpcshell/head.js 573 _execute_test ``` I've spent enough time on this test that I think it may make sense to defer fixing it to a follow-up bug. Maybe just comment out this strictEqual assert for now. It succeeds in libical, so we have an icaljs issue and not a problem with the caldav refactor changes.
Bug 1546606 Comment 25 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
(In reply to Magnus Melin [:mkmelin] from comment #24) > For figuring out where calls come from, often putting a console.trace() at the interesting place will help a bunch. Thanks, yeah, I've been using console.trace when I can't get the debugger working. It's how I got the log above. But if I put a console.trace() in the startOfWeek call I don't get any more info about how we get from JSON.stringify(first) in the test to the startOfWeek call: ``` console.trace: 0:12.96 pid:24864 resource://calendar/calendar-js/calDateTime.js 167 get startOfWeek 0:12.96 pid:24864 [...]/xpcshell/comm/calendar/test/unit/test_caldav_requests.js 903 test_freebusy_request 0:12.96 pid:24864 [...]/xpcshell/head.js 1567 run_next_test/_run_next_test/< 0:12.96 pid:24864 [...]/xpcshell/head.js 1567 _run_next_test 0:12.96 pid:24864 [...]/xpcshell/head.js 735 run 0:12.96 pid:24864 [...]/xpcshell/head.js 246 _do_main 0:12.96 pid:24864 [...]/xpcshell/head.js 573 _execute_test ``` I've spent enough time on this test that I think it may make sense to defer fixing it to a follow-up bug. Maybe just comment out this strictEqual assert for now. [EDIT: no need to comment it out, see next comment.] It succeeds in libical, so we have an icaljs issue and not a problem with the caldav refactor changes.