Bugzilla

Now using Fluent.  I couldn't get the custom button labels to work with Fluent, but the standard "Cancel"/"OK" is fine here, and arguably better, so let's just do that.

(In reply to Philipp Kewisch [:Fallen] [:📆][:🧩] from comment #50)
> 
> I guess you can't easily due to system styling of the dialog element, but
> this seems like a dialog that would be great to write in pure html without
> xul.

Yeah, good point.  Leaving it as xul for now, should be easy to convert when we convert dialogs to html.

> ::: calendar/providers/caldav/CalDavCalendar.jsm
> @@ +1426,5 @@
> > +
> > +    if (args.returnValue) {
> > +      this.uri = response.uri;
> > +      // TODO: Is this line needed?  It was used in the previous dialog.
> > +      // this.setProperty("uri", response.uri.spec);
> 
> This is what sets the calendar URI to the redirected URI, are you doing this
> somewhere else?

Ah, okay, I was thinking the line above covered that (`this.uri = response.uri`).  I should look into the difference between those two ways of setting a property.  I've put both lines in in this patch.

Now using Fluent.  I couldn't get the custom button labels to work with Fluent, but the standard "Cancel"/"OK" is fine here, and arguably better, so let's just do that.

(In reply to Philipp Kewisch [:Fallen] [:📆][:🧩] from comment #50)
> 
> I guess you can't easily due to system styling of the dialog element, but
> this seems like a dialog that would be great to write in pure html without
> xul.

Yeah, good point.  Leaving it as xul for now, should be easy to convert when we convert dialogs to html.

> ::: calendar/providers/caldav/CalDavCalendar.jsm
> @@ +1426,5 @@
> > 
> >     if (args.returnValue) {
> >       this.uri = response.uri;
> >       // TODO: Is this line needed?  It was used in the previous dialog.
> >       // this.setProperty("uri", response.uri.spec);
> 
> This is what sets the calendar URI to the redirected URI, are you doing this
> somewhere else?

Ah, okay, I was thinking the line above covered that (`this.uri = response.uri`).  I should look into the difference between those two ways of setting a property.  I've put both lines in in this patch.