I've been testing and trying to figure out what's happening here with not much luck. Since the `MozElements.NotificationBox()` class doesn't handle buttons with `type="menu-button"`, and if I'm not wrong that type is only used by TB, the button `hbox` that contains the label gets duplicated when that specific type gets applied. It also happens when you manually add that attribute through the browser inspector. I think something is happening in bug 1538983 that cause the button to regenerate the label box. I found a super hacky patch that simply deletes the label box. I'm not sure this is an acceptable approach, tho. I'm thinking we should consider using the `toolbarbutton` element and append it to the notification reminder, since this is the only location we're using the `type="menu-button"`. Thoughts?
Bug 1547238 Comment 20 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
I've been testing and trying to figure out what's happening here with not much luck. Since the `MozElements.NotificationBox()` class doesn't handle buttons with `type="menu-button"`, and if I'm not wrong that type is only used by TB, the button `hbox` that contains the label gets duplicated when that specific type gets applied. It also happens when you manually add that attribute through the browser inspector. I think something is happening in bug 1538983 that causes the button to regenerate the label box. I found a super hacky patch that simply deletes the label box. I'm not sure this is an acceptable approach, tho, but it fixes the test and remove the extra text. I'm thinking we should consider using the `toolbarbutton` element and append it to the notification reminder, since this is the only location we're using the `type="menu-button"`. Thoughts?