Bug 1547669 Comment 3 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

So I evaluated our options with Shane and Philipp, we are going to do the following:
1. add a new option to topSites.get(), as an enum string, that allows to switch mode between "frequent" and "newtab" (names are made up for now, we also need a name for the option, maybe "mode" or "sortingMode" or "resultSet"?)
2. the default for the API will remain the current result set, in the future the add-ons team will evluate whether to change the default
3. add a new property to the MostVisitedURL object, to indicate if it's a search (maybe just a type property) and again default to the current type (I suppose at the beginning the only 2 types will be "url" or "search", where url is the default).
4. if possible, provide favicons when the includeFavicon option is true, if it's hard or slow we can leave the favicons out and document that "newtab" mode doesn't yet return favicons. We can add favicon urls in the UrlbarProviderExtension object, as I said in comment 2
So I evaluated our options with Shane and Philipp, we are going to do the following:
1. add a new option to topSites.get(), as an enum string, that allows to switch mode between "frequent" and "newtab" (names are made up for now, we also need a name for the option, maybe "mode" or "sortingMode" or "resultSet"?)
2. the default for the API will remain the current result set, in the future the add-ons team will evaluate whether to change the default
3. add a new property to the MostVisitedURL object, to indicate if it's a search (maybe just a type property) and again default to the current type (I suppose at the beginning the only 2 types will be "url" or "search", where url is the default).
4. if possible, provide favicons when the includeFavicon option is true, if it's hard or slow we can leave the favicons out and document that "newtab" mode doesn't yet return favicons. We can add favicon urls in the UrlbarProviderExtension object, as I said in comment 2

Back to Bug 1547669 Comment 3