Bug 1551090 Comment 3 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Cameron McCormack (:heycam) from comment #2)
> Daniel, is this a known difference between our -webkit-box implementation and Blink/WebKit's?  Is this something we should fix?

No, I don't think it's a known difference.

Yes, it's probably something we should fix.  In case I don't get to it and someone else wants to take a look: we probably need a special case in `nsCSSFrameConstructor::FrameConstructionItem::NeedsAnonFlexOrGridItem()`, for the aIsLegacyBox==true case.
https://searchfox.org/mozilla-central/rev/8308eb7ea14318f53b55f3289c2bb9b712265318/layout/base/nsCSSFrameConstructor.cpp#11781

(Or, if the whitespace has already been discarded by that point, perhaps we need a special case up a few levels in `nsCSSFrameConstructor::CreateNeededAnonFlexOrGridItems` or nearby.)
(In reply to Cameron McCormack (:heycam) from comment #2)
> Daniel, is this a known difference between our -webkit-box implementation and Blink/WebKit's?  Is this something we should fix?

No, I don't think it's a known difference.

Yes, it's probably something we should fix.  In case I don't get to it and someone else wants to take a look: we probably need a special case in `nsCSSFrameConstructor::FrameConstructionItem::NeedsAnonFlexOrGridItem()`, for the aIsLegacyBox==true case.
https://searchfox.org/mozilla-central/rev/8308eb7ea14318f53b55f3289c2bb9b712265318/layout/base/nsCSSFrameConstructor.cpp#11781

(Or, if the whitespace has already been discarded by that point and the function doesn't even get to consider it, then perhaps we need a special case up a few levels in `nsCSSFrameConstructor::CreateNeededAnonFlexOrGridItems` or nearby.)

Back to Bug 1551090 Comment 3