Bug 1553165 Comment 1 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

I added a simple log into the aforementioned method and it shows that the `this._netEvents` map is cleared only when closing the entire Toolbox. So, reloads (with Persist Logs == false) are only adding new actors into it (not removing).

Honza

```js
diff --git a/devtools/server/actors/network-monitor.js b/devtools/server/actors/network-monitor.js
--- a/devtools/server/actors/network-monitor.js
+++ b/devtools/server/actors/network-monitor.js
@@ -196,16 +196,18 @@ const NetworkMonitorActor = ActorClassWi
     const actor = this.getNetworkEventActor(data.channelId);
     this.messageManager.sendAsyncMessage("debug:get-network-event-actor:response", {
       channelId: data.channelId,
       actor: actor.form(),
     });
   },

   getNetworkEventActor(channelId) {
+    console.log("getNetworkEventActor " + channelId + ", " + this._netEvents.size);
+
     let actor = this._netEvents.get(channelId);
     if (actor) {
       return actor;
     }

     actor = new NetworkEventActor(this);
     this.manage(actor);
```
I added a simple log into the aforementioned method and it shows that the `this._netEvents` map is cleared only when closing the entire Toolbox. So, reloads (with Persist Logs == false) are only adding new actors into it (not removing). Clearing Network panel content has also no effect on that array.

Honza

```js
diff --git a/devtools/server/actors/network-monitor.js b/devtools/server/actors/network-monitor.js
--- a/devtools/server/actors/network-monitor.js
+++ b/devtools/server/actors/network-monitor.js
@@ -196,16 +196,18 @@ const NetworkMonitorActor = ActorClassWi
     const actor = this.getNetworkEventActor(data.channelId);
     this.messageManager.sendAsyncMessage("debug:get-network-event-actor:response", {
       channelId: data.channelId,
       actor: actor.form(),
     });
   },

   getNetworkEventActor(channelId) {
+    console.log("getNetworkEventActor " + channelId + ", " + this._netEvents.size);
+
     let actor = this._netEvents.get(channelId);
     if (actor) {
       return actor;
     }

     actor = new NetworkEventActor(this);
     this.manage(actor);
```

Back to Bug 1553165 Comment 1