Bug 1553927 Comment 6 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Honza Bambas (:mayhemer) from comment #5)
> I think we could just disable this check when the channel's uri schema is "http" or when the channel is a detect-portal check

I think that's a good fix too.

> (I wonder if that would ever become https uri?)

Users can technically set the URL to be a `https` one. I assume it rarely happens, as it kinda defeats the purpose. Some captive portals simply time out or block HTTPS connections, so it would completely fail to detect those networks.
(In reply to Honza Bambas (:mayhemer) from comment #5)
> I think we could just disable this check when the channel's uri schema is "http" or when the channel is a detect-portal check

I think that's a good fix too. Note: I don't know if we have a good way of detecting if `the channel is a detect-portal check`

> (I wonder if that would ever become https uri?)

Users can technically set the URL to be a `https` one. I assume it rarely happens, as it kinda defeats the purpose. Some captive portals simply time out or block HTTPS connections, so it would completely fail to detect those networks.

Back to Bug 1553927 Comment 6