Bug 1554009 Comment 2 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Thanks for filing Emilio! 

I think it is used in various places. Basically we are checking it in various places the check that a given rule actually applies to the current element.

So I think I have STRs for this bug in DevTools:
- go to https://juliandescottes.github.io/webcomponents-playground/slotted-selector/ 
- inspect the "green" container
Expected result: In the rule view, the rule `background: rgb(255, 0, 0);` should be marked as overridden (greyed + strikethrough)
Actual result:  In the rule view, the rule `background: rgb(255, 0, 0);` has the default style.

This is related to the following code https://searchfox.org/mozilla-central/rev/662de518b1686c4769320d6b8825ce4864c4eda0/devtools/client/inspector/rules/models/element-style.js#285 . Basically we don't update properly this rule because we think it doesn't really apply to the element.

So it's probably not used in critical paths, that's why we didn't get any bug report so far. But it would be great to fix it!
Emilio do you have more pointers to fix this by any chance?
Thanks for filing Emilio! 

I think it is used in various places. Basically we are checking it in various places the check that a given rule actually applies to the current element.

So I think I have STRs for this bug in DevTools:
- go to https://juliandescottes.github.io/webcomponents-playground/slotted-selector/ 
- inspect the "green" container

Expected result: In the rule view, the rule `background: rgb(255, 0, 0);` should be marked as overridden (greyed + strikethrough)
Actual result:  In the rule view, the rule `background: rgb(255, 0, 0);` has the default style.

This is related to the following code https://searchfox.org/mozilla-central/rev/662de518b1686c4769320d6b8825ce4864c4eda0/devtools/client/inspector/rules/models/element-style.js#285 . Basically we don't update properly this rule because we think it doesn't really apply to the element.

So it's probably not used in critical paths, that's why we didn't get any bug report so far. But it would be great to fix it!
Emilio do you have more pointers to fix this by any chance?

Back to Bug 1554009 Comment 2