Here is a case where I tried to use Lando to land a patch written by a contributor (Greg) but failed and had to fall back to mozilla-inbound. The patch in question is [D27983](https://phabricator.services.mozilla.com/D27983). I believe it was originally submitted by pasting the output of `git diff` into the Phabricator web UI. Lando gave me this error about it: "Diff does not have proper author information in Phabricator. See the Lando FAQ for help with this error." The linked FAQ item seemed to suggest setting up moz-phab, but it appears that's complicated if you're using git? Quoting from [Greg's comment](https://phabricator.services.mozilla.com/D27983#951189): > I didn't want to set up the whole git-cinnabar + *custom fork of arc* thing. I've been working with the github.com/mozilla/gecko-dev mirror — can I even convert to the hg cinnabar remote without re-cloning? > > Why is all this complexity required just for *author information* of all things? That's just ridiculous >_< I suggested running `git format-patch` and pasting the generated diff file into the web UI rather than the output of `git diff`, since the diff generated by `git format-patch` includes an `Author: ...` header line with the relevant information. However, Phabricator did not seem to pick up on that and the Lando error about not having proper author information persisted. It would be nice to reduce the friction here. In particular, since `git format-patch` generates a file containing the relevant information, Phabricator should be able to pick that up and use it even if it's pasted into the web UI.
Bug 1554274 Comment 0 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Here is a case where I tried to use Lando to land a patch written by a contributor (Greg) but failed and had to fall back to mozilla-inbound. The patch in question is [D27983](https://phabricator.services.mozilla.com/D27983). I believe it was originally submitted by pasting the output of `git diff` into the Phabricator web UI. Lando gave me this error about it: "Diff does not have proper author information in Phabricator. See the Lando FAQ for help with this error." The linked FAQ item seemed to suggest setting up moz-phab, but it appears that's complicated if you're using git? Quoting from [Greg's comment](https://phabricator.services.mozilla.com/D27983#951189): > I didn't want to set up the whole git-cinnabar + *custom fork of arc* thing. I've been working with the github.com/mozilla/gecko-dev mirror — can I even convert to the hg cinnabar remote without re-cloning? > > Why is all this complexity required just for *author information* of all things? That's just ridiculous >_< I suggested running `git format-patch` and pasting the generated diff file into the web UI rather than the output of `git diff`, since the diff generated by `git format-patch` includes an `Author: ...` header line with the relevant information. However, Phabricator did not seem to pick up on that and the Lando error about not having proper author information persisted. As mentioned, I ended up just landing the patch manually onto mozilla-inbound. It would be nice to reduce the friction here. In particular, since `git format-patch` generates a file containing the relevant information, Phabricator should be able to pick that up and use it even if it's pasted into the web UI.